🚑 Fix Processed Trip Survey Responses Not Matching #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Processed responses for user input surveys were not being matched because they were being looked up under "manual/trip_user_input", while it should have just been "trip_user_input". This is because we were only invoking a function to trim off "manual/" for MULTILABEL user input matching, and it was neglected for ENKETO. Revise the functions in confirmHelper (keeping 2 versions, `removeManualPrefix` which just trims the key, and `inputType2retKey` which looks up the key and then trims), and use `removeManualPrefix` in inputMatcher appropriately Some day we can unify the data model (e-mission/e-mission-docs#1045) and not keep 2 versions of so many things
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## service_rewrite_2023 #1125 +/- ##
========================================================
+ Coverage 74.98% 77.55% +2.57%
========================================================
Files 28 28
Lines 1699 1702 +3
Branches 367 367
========================================================
+ Hits 1274 1320 +46
+ Misses 425 382 -43
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Adds basic unit tests for mapInputsToTimelineEntries under both MULTILABEL and ENKETO configurations. It considers fake user inputs that are processed, and those that are unprocessed, and ensures that the returned map includes both.
|
Added some basic tests for |
|
@shankari for visibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Processed responses for user input surveys were not being matched because they were being looked up under "manual/trip_user_input", while it should have just been "trip_user_input". This is because we were only invoking a function to trim off "manual/" for MULTILABEL user input matching, and it was neglected for ENKETO.
Revise the functions in confirmHelper (keeping 2 versions,
removeManualPrefixwhich just trims the key, andinputType2retKeywhich looks up the key and then trims), and useremoveManualPrefixin inputMatcher appropriatelySome day we can unify the data model (e-mission/e-mission-docs#1045) and not keep 2 versions of so many things