Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change timeout for React Component test from 5s to 15s #1103

Merged

Conversation

jiji14
Copy link
Contributor

@jiji14 jiji14 commented Nov 14, 2023

Change timeout for React Component test from 5s to 15s

Why the test fails on GitHub Actions Environment

The test fails with the message Exceeded timeout of 5000 ms for a test in the GitHub Actions environment. In Jest, the default test timeout is 5 seconds, which might be too short for React component testing. I guess this could happen in component tests where we trigger actions, render components, and check if the component exists or if the function gets called.

What is changed to fix this issue

During our regular meeting, we reached an agreement to extend the timeout from 5 seconds to 15 seconds.

We will further discuss how to handle this issue, especially considering that as we write more component tests, this issue may arise again.

For more details, refer to Jest documentation.

@jiji14 jiji14 marked this pull request as draft November 14, 2023 20:06
@jiji14 jiji14 changed the title Change timeout for the test from 5s to 15s Change timeout for React Component test from 5s to 15s Nov 14, 2023
@jiji14 jiji14 marked this pull request as ready for review November 14, 2023 20:37
@shankari
Copy link
Contributor

Merging this as a workaround.

@shankari shankari merged commit e0d892f into e-mission:service_rewrite_2023 Nov 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants