-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
‼️📅 Rewrite - notifScheduler.ts #1092
Merged
shankari
merged 42 commits into
e-mission:service_rewrite_2023
from
sebastianbarry:notifScheduler-rewrite
Jan 20, 2024
Merged
Changes from 41 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
4abe86d
Add notifScheduler.ts
sebastianbarry da87f47
Merge branch 'service_rewrite_2023' into notifScheduler-rewrite
sebastianbarry 1bfb113
Merge branch 'service_rewrite_2023' into notifScheduler-rewrite
sebastianbarry 131eca5
Format notifScheduler.ts
sebastianbarry cc7664f
Merge branch 'service_rewrite_2023' into notifScheduler-rewrite
sebastianbarry 39986a3
Temporary any type, handled purely in notifScheduler getReminderPrefs
sebastianbarry 58539ca
Undoing imports getting duplicated during prettier changes
sebastianbarry 384ffe8
Replace console.log with logger.ts's displayErrorMsg
sebastianbarry 9d3c718
Move scheduledNotifs into the only function that uses it
sebastianbarry a1e035f
Remove console.errors that I was using for debugging
sebastianbarry 8b09cb3
Adding Luxon functions
sebastianbarry 96d1d50
Update notifscheduler to export functions instead of using hooks
sebastianbarry a6d99e7
Run prettier on non-pretty code
sebastianbarry b0da6e9
Remove old Angular notifScheduler.js
sebastianbarry 6b9d222
Add the reminderSchemes as an argument to called getReminderPrefs
sebastianbarry 97571ee
Added typing for User object in getReminderPrefs
sebastianbarry a29705d
Restructure promise format and replaced moment with Luxon
sebastianbarry 9b4b1d0
Merge branch 'service_rewrite_2023' of https://github.com/e-mission/e…
JGreenlee ba239e6
Resolve the app crashing errors
sebastianbarry 2f75de9
Remove unnecessary imports
sebastianbarry 5e572d4
notif-scheduling-state variables kept in ProfileSettings.jsx and hand…
sebastianbarry db91c8c
Remove empty objects from notifs, fixing the "n.trigger.at does not e…
sebastianbarry e4817da
Added removeEmptyObjects check to the other cordova plugin getSchedul…
sebastianbarry 0ee468a
Added sorting to list of notifications right before they get scheduled
sebastianbarry e209f10
Change static variable isScheduling to a useState
sebastianbarry b8bf1cf
Replace console.logs with logDebugs
sebastianbarry b27ae9a
Add in more type declarations
sebastianbarry abbe618
Add Jest Testing - getScheduledNotifs
sebastianbarry fbd1b62
Add first updateScheduledNotifs test
sebastianbarry 87fdae5
Add reminder scheme missing test for updateScheduledNotifs
sebastianbarry 214081e
Add already scheduled notifs test
sebastianbarry f5ebb1e
Fixing comments
sebastianbarry 6892580
Final overall test for updateScheduledNotifs
sebastianbarry e8b449f
Merge branch 'service_rewrite_2023' of https://github.com/e-mission/e…
JGreenlee 85f0519
Added user exists test for getReminderPrefs
sebastianbarry 0528fb0
Remove unnecessary console.log
sebastianbarry 2c0ec40
Fixing moved location of commHelper causing jest tests to fail
sebastianbarry 35ffc41
Merge branch 'service_rewrite_2023' of https://github.com/e-mission/e…
JGreenlee 4e44dba
fix error on configs without reminderSchemes
JGreenlee 5ee4d64
Add getReminderPrefs test for when user does not exist
sebastianbarry d3750c3
Add simple setReminderPrefs test
sebastianbarry ec9729d
Add test for updateScheduledNotifs to test if notifs successfully get…
sebastianbarry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are keeping the
logDebug
tests, we should change this fromconsole.log
tologDebug
so we can test the alerting behavior.