-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prettier Setup #1068
Closed
Closed
Prettier Setup #1068
Changes from 6 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
00f07ef
setup prettier (not done)
jiji14 d3132a1
update prettier setting based on team's suggestion
jiji14 3163c34
add prettierignore to exclude files from formmating
jiji14 5551d90
add prettier package
jiji14 d4f12f0
Apply prettier into input-matcher.js for test
jiji14 66df762
use bracketSameLine instead of jsxBracketSameLine
jiji14 c2004d5
apply Prettier to ts file for testing
jiji14 dcc1bfc
apply Prettier to tsx file for testing
jiji14 bd90997
Add files for prettier ignore
jiji14 de31a2c
Run prettier for the entire codes
jiji14 8ec6fed
Revert "Add files for prettier ignore"
jiji14 975baea
Revert "Run prettier for the entire codes"
jiji14 14d0294
Merge remote-tracking branch 'upstream/master' into prettier-setup
jiji14 0c33e0c
Redo) Add files into .prettierignore
jiji14 842caf0
Redo) Run prettier for the entire files
jiji14 ae8df4f
Revert "Redo) Run prettier for the entire files"
jiji14 b15d8fb
only targets 'www' directory except 'www/dist'
jiji14 7cd14a3
Ignore www/manual_lib and www/json
jiji14 7ce81c4
Delete the file because we no longer need it with prettier
jiji14 bbd10a4
delete unnecessary line
jiji14 e2188da
Update .prettierignore
JGreenlee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| node_modules | ||
| # Ignore artifacts: | ||
| build | ||
| coverage | ||
jiji14 marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "printWidth": 100, | ||
| "tabWidth": 2, | ||
| "singleQuote": true, | ||
| "trailingComma": "all", | ||
| "bracketSpacing": true, | ||
| "bracketSameLine": true, | ||
| "endOfLine": "lf", | ||
| "semi": true | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it will also be necessary to ignore the
platformsdirectory, and maybewww/distIs there no way to target Prettier at only the
wwwfolder?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/manual_liband/jsonmust be ignored as wellThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all of your advices!
I found the pattern only check
wwwdirectory withoutdist,manual_lib, andjson.Can you please confirm this? 🙏
I ran prettier script locally with this setting and it worked well! I will push the code again if we don't need to add more files in
.prettierignore!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the strategy is to ignore everything except
www, you can removenode_modulesand the artifacts since these are already ignored by the/*ruleThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I missed that! Thanks :) I deleted the line!