🐛 Backwards Compat Fix for New Onboarding #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the old "Logout" functionality cleared the UI config but not other storage keys, such as those for marking consented and marking intro done. A backwards-compat check is needed: if the UI config is blank but intro done or consented are marked true, we need to clear everything.
shankari
approved these changes
Oct 5, 2023
shankari
merged commit 0c5cd0e
into
e-mission:onboarding_routing_sept_2023
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old "Logout" functionality cleared the UI config but not other storage keys, such as those for marking consented and marking intro done.
A backwards-compat check is needed: if the UI config is blank but intro done or consented are marked true, we need to clear everything.