complete writing testing

adding more tests - leveraged mocks to ensure that calls to open url or create popup were happening at the appropriate times

www/__mocks__/cordovaMocks.ts

@@ -167,3 +167,22 @@ export const mockBEMServerCom = () => {
   };
   window['cordova'].plugins.BEMServerComm = mockBEMServerCom;
 };
+
+let _url_stash = '';
+
+export const mockInAppBrowser = () => {
+  const mockInAppBrowser = {
+    open: (url: string, mode: string, options: {}) => {
+      _url_stash = url;
+    },
+  };
+  window['cordova'].InAppBrowser = mockInAppBrowser;
+};
+
+export const getURL = () => {
+  return _url_stash;
+};
+
+export const clearURL = () => {
+  _url_stash = '';
+};

www/__mocks__/globalMocks.ts

@@ -1,3 +1,19 @@
 export const mockLogger = () => {
   window['Logger'] = { log: console.log };
 };
+
+let alerts = [];
+
+export const mockAlert = () => {
+  window['alert'] = (message) => {
+    alerts.push(message);
+  };
+};
+
+export const clearAlerts = () => {
+  alerts = [];
+};
+
+export const getAlerts = () => {
+  return alerts;
+};

www/__tests__/remoteNotifyHandler.test.ts

@@ -1,15 +1,29 @@
 import { EVENT_NAMES, publish } from '../js/customEventHandler';
 import { initRemoteNotifyHandler } from '../js/splash/remoteNotifyHandler';
-import { mockBEMUserCache, mockDevice, mockGetAppVersion } from '../__mocks__/cordovaMocks';
-import { mockLogger } from '../__mocks__/globalMocks';
+import {
+  clearURL,
+  getURL,
+  mockBEMUserCache,
+  mockDevice,
+  mockGetAppVersion,
+  mockInAppBrowser,
+} from '../__mocks__/cordovaMocks';
+import { clearAlerts, getAlerts, mockAlert, mockLogger } from '../__mocks__/globalMocks';
 
 mockLogger();
 mockDevice();
 mockBEMUserCache();
 mockGetAppVersion();
+mockInAppBrowser();
+mockAlert();
 
 const db = window['cordova']?.plugins?.BEMUserCache;
 
+beforeEach(() => {
+  clearURL();
+  clearAlerts();
+});
+
 it('does not adds a statEvent if not subscribed', async () => {
   publish(EVENT_NAMES.CLOUD_NOTIFICATION_EVENT, 'test data');
   const storedMessages = await db.getAllMessages('stats/client_nav_event', false);
@@ -31,3 +45,32 @@ it('adds a statEvent if subscribed', async () => {
   });
 });
 
+it('handles the url if subscribed', () => {
+  initRemoteNotifyHandler();
+  publish(EVENT_NAMES.CLOUD_NOTIFICATION_EVENT, {
+    additionalData: {
+      payload: { alert_type: 'website', spec: { url: 'https://this_is_a_test.com' } },
+    },
+  });
+  expect(getURL()).toBe('https://this_is_a_test.com');
+});
+
+it('handles the popup if subscribed', () => {
+  initRemoteNotifyHandler();
+  publish(EVENT_NAMES.CLOUD_NOTIFICATION_EVENT, {
+    additionalData: {
+      payload: {
+        alert_type: 'popup',
+        spec: { title: 'Hello', text: 'World' },
+      },
+    },
+  });
+  expect(getAlerts()).toEqual(expect.arrayContaining(['━━━━\nHello\n━━━━\nWorld']));
+});
+
+it('does nothing if subscribed and no data', () => {
+  initRemoteNotifyHandler();
+  publish(EVENT_NAMES.CLOUD_NOTIFICATION_EVENT, {});
+  expect(getURL()).toEqual('');
+  expect(getAlerts()).toEqual([]);
+});