Skip to content

Commit

Permalink
remove jQuery from dependencies + webpack
Browse files Browse the repository at this point in the history
When using AngularJS, jQuery needed to be provided as a global by Webpack. Now, we do not need it at all (except Enketo which still uses jQuery internally, but provides it to itself and is not needed globally.)
  • Loading branch information
JGreenlee committed Jan 26, 2024
1 parent 004b9ea commit 48633c3
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 5 deletions.
1 change: 0 additions & 1 deletion package.cordovabuild.json
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@
"humanize-duration": "^3.31.0",
"i18next": "^23.7.6",
"install": "^0.13.0",
"jquery": "^3.1.0",
"klaw-sync": "^6.0.0",
"leaflet": "^1.9.4",
"luxon": "^3.3.0",
Expand Down
1 change: 0 additions & 1 deletion package.serve.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@
"humanize-duration": "^3.31.0",
"i18next": "^23.7.6",
"install": "^0.13.0",
"jquery": "^3.1.0",
"klaw-sync": "^6.0.0",
"leaflet": "^1.9.4",
"luxon": "^3.3.0",
Expand Down
4 changes: 1 addition & 3 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,8 @@ module.exports = {
],
},
plugins: [
// to load jQuery globally
// to load Leaflet globally
new webpack.ProvidePlugin({
$: 'jquery',
jQuery: 'jquery',
L: 'leaflet',
}),
new webpack.DefinePlugin({
Expand Down

0 comments on commit 48633c3

Please sign in to comment.