Skip to content

Commit

Permalink
🔥 Remove the pinned npm version; use the node default
Browse files Browse the repository at this point in the history
We had a pinned npm version, but we didn't actually use it,
using the default version in node instead. As long as we have
a reasonbly recent version of node, that seems like it will work.
It is still pinned (just pinned implicitly by the node pin), and we don't
actually use the pinned version now anyway.

Yay for simplicity and not keeping bitrotted code around...
  • Loading branch information
shankari committed Aug 27, 2024
1 parent 399e9e7 commit 4377e43
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 12 deletions.
3 changes: 0 additions & 3 deletions setup/activate_shared.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,3 @@ echo "Activating nvm"

echo "Using version $NODE_VERSION"
nvm use $NODE_VERSION

CURR_NPM_VERSION=`npm --version`
echo "npm version = $CURR_NPM_VERSION"
1 change: 0 additions & 1 deletion setup/export_shared_dep_versions.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
export NVM_VERSION=0.40.0
export NODE_VERSION=20.9.0
export NPM_VERSION=10.8.2
# make sure that this is a stable version from
# so that https://github.com/postmodern/ruby-versions
# ideally, this would be the same version as the CI
Expand Down
8 changes: 0 additions & 8 deletions setup/setup_shared.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,3 @@ echo "Setting up the variables to run nvm"

echo "Installing the correct node version"
nvm install $NODE_VERSION

echo "Check the version of npm"
CURR_NPM_VERSION=`npm --version`
if [ $CURR_NPM_VERSION != $NPM_VERSION ];
then
echo "Invalid npm version, expected $NPM_VERSION, got $CURR_NPM_VERSION"
npm install npm@$NPM_VERSION
fi

0 comments on commit 4377e43

Please sign in to comment.