Skip to content

Commit

Permalink
🎨 Escape quotes in the android strings
Browse files Browse the repository at this point in the history
Without this change, build failed with

```
/Users/runner/work/e-mission-phone/e-mission-phone/platforms/android/app/src/main/res/values/dc_strings.xml:20:4: Failed to flatten XML for resource 'location_permission_off' with error: Invalid unicode escape sequence in string
> Task :app:mergeDebugResources FAILED
"{str}"
/Users/runner/work/e-mission-phone/e-mission-phone/platforms/android/app/src/main/res/values/dc_strings.xml:20:4: string/location_permission_off does not contain a valid string resource.
/Users/runner/work/e-mission-phone/e-mission-phone/platforms/android/app/src/main/res/values/dc_strings.xml:27:4: Failed to flatten XML for resource 'location_permission_off_app_open' with error: Invalid unicode escape sequence in string
"{str}"
/Users/runner/work/e-mission-phone/e-mission-phone/platforms/android/app/src/main/res/values/dc_strings.xml:27:4: string/location_permission_off_app_open does not contain a valid string resource.
```

With the change, build succeeds
  • Loading branch information
shankari committed Oct 7, 2024
1 parent 775e717 commit 9c034bc
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions res/android/values/dc_strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
<!-- TripDiaryStateMachineService and Ongoing-->
<string name="success_moving_new_state">Success moving to %1$s</string>
<string name="failed_moving_new_state">Failed moving to %1$s</string>
<string name="location_permission_off">Insufficient permissions, please allow 'Always' and 'Precise' location access</string>
<string name="location_permission_off_app_open">Insufficient permissions, please select 'Always' and 'Precise' location access in app settings</string>
<string name="location_permission_off">Insufficient permissions, please allow \'Always\' and \'Precise\' location access</string>
<string name="location_permission_off_app_open">Insufficient permissions, please select \'Always\' and \'Precise\' location access in app settings</string>
<string name="location_permission_intermediary_title">Permissions Needed!</string>
<string name="location_permission_intermediary_message">Further location permission needed. In order to use this app you need to click \"Allow all the time\" on the next page.</string>
<string name="location_feedback_both_off">Please make sure \"Allow all the time\" and \"Precise Location\" are turned on in the settings.</string>
Expand Down

0 comments on commit 9c034bc

Please sign in to comment.