Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to use path-style S3 URLs. #21

Merged
merged 4 commits into from
Dec 19, 2014

Conversation

grampajoe
Copy link
Contributor

It's sometimes desirable to use path-style URLs over virtual-host-style URLs. For example, a bucket name with a dot in it will trigger invalid SSL certificate errors on some browsers, since S3's *.s3.amazonaws.com certificate only covers single-level subdomains.

This adds the S3_URL_STYLE setting, which can be one of 'host' or 'path', defaulting to 'host' for compatibility.

@e-dard
Copy link
Owner

e-dard commented Feb 10, 2014

Thanks. Probably going to take a while to look at this, since there are a couple of PRs on the go at the moment, which you may need to rebase from if they're merged. 😄

@e-dard
Copy link
Owner

e-dard commented May 2, 2014

any thoughts on this, @eriktaubeneck ?

@eriktaubeneck
Copy link
Collaborator

It looks clean to me. I'm not sure I completely understand the motivation, but I don't think it overcomplicates anything.

@grampajoe
Copy link
Contributor Author

Yeah, my example was kind of unclear.

Say you have a bucket called all.the.things. If you use a host-style URL, that's all.the.things.s3.amazonaws.com/<key>, which needs its own SSL cert since it won't be covered by the one Amazon provides for *.s3.amazonaws.com. You can avoid having to pay for that by using a path-style url, s3.amazonaws.com/all.the.things/<key>, instead.

@eriktaubeneck
Copy link
Collaborator

This should take care of #20 then as well. @e-dard do you want to merge this in?

@eriktaubeneck eriktaubeneck merged commit 4a73903 into e-dard:master Dec 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants