Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new tests to provide bug if blueprint with subdomain #20

Closed
wants to merge 1 commit into from
Closed

Add new tests to provide bug if blueprint with subdomain #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion tests/test_flask_static.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,14 @@ def b():
bp = Blueprint('admin', __name__, static_folder='admin-static')
@bp.route('/<url_for_string>')
def c():
return render_template_string("{{url_for('b')}}")
return render_template_string("{{url_for('c')}}")
self.app.register_blueprint(bp)

bp_with_subdomain = Blueprint('settings', __name__, static_folder='billing-static', subdomain='billing')
@bp_with_subdomain.route('/<url_for_string>')
def d():
return render_template_string("{{url_for('d')}}")
self.app.register_blueprint(bp_with_subdomain)

def client_get(self, ufs):
FlaskS3(self.app)
Expand Down Expand Up @@ -121,6 +126,21 @@ def test_url_for_cdn_domain(self):
exp = 'https://foo.cloudfront.net/static/bah.js'
self.assertEquals(self.client_get(ufs).data, exp)

def test_url_for_blueprint_with_subdomain(self):
"""
Tests that correct url formed for static asset in blueprint with subdomain.
"""
# static endpoint url_for in template
ufs = "{{url_for('settings.static', filename='bah.js')}}"
exp = 'https://foo.s3.amazonaws.com/billing/billing-static/bah.js'
self.assertEquals(self.client_get(ufs).data, exp)


def test_url_for_cdn_domain_for_blueprint_with_subdomain(self):
self.app.config['S3_CDN_DOMAIN'] = 'foo.cloudfront.net'
ufs = "{{url_for('settings.static', filename='bah.js')}}"
exp = 'https://foo.cloudfront.net/billing/billing-static/bah.js'
self.assertEquals(self.client_get(ufs).data, exp)


class S3Tests(unittest.TestCase):
Expand Down