Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hp Deep: EventList Page and Overall Theming #2

Open
wants to merge 13 commits into
base: frontend
Choose a base branch
from

Conversation

HarshHp13
Copy link

No description provided.

@HarshHp13
Copy link
Author

EventList Page and overall theming

Copy link
Collaborator

@shubhanshu02 shubhanshu02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @HarshHp13 and @iDeepverma 🙌 🔥! The website looks great on the dark theme.

Just a few suggestions on my side regarding the Navbar and theming.

  • Consider the case where the user scrolls to some part of the page where the text on the page overlaps with text on the navbar. Here, both are not readable and seem a bit odd. To give an example, see below.
    image

  • For the light theme, the colors are kind of too bright. I guess we need to discuss with the design team to work out on colors.
    image

  • Homepage: The "Sponsor Broucher" and "Sponsor Us" buttons overlap on smaller screen widths like iPhone 12 Pro.
    image

@shubhanshu02
Copy link
Collaborator

Regarding the event details page, I'll review in some time

@shubhanshu02
Copy link
Collaborator

For the page /events

  • The links for individual events are not added to the event, even though the entire div is acting as a button. (In older versions of the website, this will point to the individual event page. E.g. /events/ctf). This is working fine for the cards on mobile devices.
  • Width of the following card is fixed to 796px, instead use a relative size.
    Screenshot from 2022-09-24 04-10-15
  • The background color of image in the card for individual events needs to be changed to a better background.
    image

@shubhanshu02 shubhanshu02 changed the title Hp deep Hp Deep: EventList Page and Overall Theming Sep 23, 2022
@netlify
Copy link

netlify bot commented Sep 24, 2022

Deploy Preview for codefest-frontend failed.

Name Link
🔨 Latest commit 3a730a4
🔍 Latest deploy log https://app.netlify.com/sites/codefest-frontend/deploys/632eded5cf5a260009a53ac0

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for codefest-frontend ready!

Name Link
🔨 Latest commit 4087008
🔍 Latest deploy log https://app.netlify.com/sites/codefest-frontend/deploys/64e11ed8298c5d00083a403e
😎 Deploy Preview https://deploy-preview-2--codefest-frontend.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants