-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hp Deep: EventList Page and Overall Theming #2
base: frontend
Are you sure you want to change the base?
Conversation
EventList Page and overall theming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @HarshHp13 and @iDeepverma 🙌 🔥! The website looks great on the dark theme.
Just a few suggestions on my side regarding the Navbar and theming.
-
Consider the case where the user scrolls to some part of the page where the text on the page overlaps with text on the navbar. Here, both are not readable and seem a bit odd. To give an example, see below.
-
For the light theme, the colors are kind of too bright. I guess we need to discuss with the design team to work out on colors.
-
Homepage: The "Sponsor Broucher" and "Sponsor Us" buttons overlap on smaller screen widths like iPhone 12 Pro.
Regarding the event details page, I'll review in some time |
❌ Deploy Preview for codefest-frontend failed.
|
✅ Deploy Preview for codefest-frontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
No description provided.