Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(screengrab): file url parsing error in case of quoted special chars #644

Merged
merged 4 commits into from
May 13, 2024
Merged

fix(screengrab): file url parsing error in case of quoted special chars #644

merged 4 commits into from
May 13, 2024

Conversation

supersonictw
Copy link
Contributor

@supersonictw supersonictw commented May 13, 2024 •
edited
Loading

Try to fix for #643

@supersonictw supersonictw changed the title fix(dbus_portal.py): decode utf-8 on file scheme uri Decode utf-8 on file scheme uri May 13, 2024
@supersonictw supersonictw changed the title Decode utf-8 on file scheme uri Decode UTF-8 on file scheme URI May 13, 2024
@dynobo dynobo changed the title Decode UTF-8 on file scheme URI fix(screengrab): file url parsing error in case of quoted special chars May 13, 2024
@dynobo dynobo self-requested a review May 13, 2024 16:17
dynobo
dynobo approved these changes May 13, 2024
View reviewed changes
Copy link
Owner

@dynobo dynobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @supersonictw, for reporting and already fixing this issue! 🚀

normcap/screengrab/handlers/dbus_portal.py Outdated Show resolved Hide resolved
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 84.888% (-0.02%) from 84.911%
when pulling f3526eb on supersonictw:main
into b347d48 on dynobo:main.

@dynobo dynobo merged commit ac0e780 into dynobo:main May 13, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dynobo dynobo dynobo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@supersonictw @coveralls @dynobo