-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#261 Improve MC computation to have all procs available running jobs. #262
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a nrt that exercise this
By design all nrts already exercise this. And no way to check it from an nrt point of view as this behavior is not always active if at some point there is not enough jobs to run... |
the log of the MC should reflect that |
There are no logs as reference |
No, but it might be the right time to add it |
I am not sure we have something to compare those two logs... |
1be8dde
to
f537a87
Compare
The log comparison already exists in dynawo, the only things to do is to add the logs in reference and modify the filter in the LineToCompare function in nrtDiff.py |
I will add the logs file prior to this PR to see a difference. #308 |
Signed-off-by: Gautier Bureau <[email protected]>
f537a87
to
d4e08cc
Compare
It seems that the nrt are passing even without updating the logs which is surprising |
I think we don't use enough procs to activate the behavior... |
I think we use 2, we need a test of this behavior somehow to avoid silent regressions |
I agree |
Checklist before requesting a review
use
'[x]'
to check the checkboxes, or submit the PR and then click the checkboxes