Merged PR 12366: #18350 - add to favorites typo + cart updatefromurl …

…overload fix #18350 - add to favorites typo + cart updatefromurl overload fix Related work items: #18350
dynamicweb · Mar 5, 2024 · b8f3995 · b8f3995
2 parents ed14f6a + 8802e6e
commit b8f3995
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/Swift/Files/Templates/Designs/Swift/Assets/_src/js/_favorites.js b/Swift/Files/Templates/Designs/Swift/Assets/_src/js/_favorites.js
@@ -86,7 +86,7 @@ const Favorites = function () {
 			var favoriteNotification = document.querySelector("#favoriteNotificationToast");
 
 			//Fire the 'updated'´event
-			let event = new CustomEvent("updated.swift.cart", {
+			let event = new CustomEvent("updated.swift.favorites", {
 				cancelable: true,
 				detail: {
 					formData: formData

diff --git a/Swift/Files/Templates/Designs/Swift/Assets/_src/js/_pageupdater.js b/Swift/Files/Templates/Designs/Swift/Assets/_src/js/_pageupdater.js
@@ -95,7 +95,7 @@ const PageUpdater = function () {
 			}
 		},
 
-		UpdateFromUrl: async function (e, url, layout, target) {
+		UpdateFromUrlInline: async function (e, url, layout, target) {
 
 			var layoutTemplate = layout != undefined ? layout : "Swift_PageClean.cshtml";
 			url += "&LayoutTemplate=" + layoutTemplate;

diff --git a/Swift/Files/Templates/Designs/Swift/Swift_Master.cshtml b/Swift/Files/Templates/Designs/Swift/Swift_Master.cshtml
@@ -509,7 +509,7 @@
 
 				const updateCartSummary = (orderContext) => {
 					const dynamicOffcanvas = document.getElementById('DynamicOffcanvas');
-					swift.PageUpdater.UpdateFromUrl(event, '/Default.aspx?ID=@(cartSummaryPageId)&CartType=minicart&RequestPageID=@(Pageview.Page.ID)&OrderContext=' + orderContext +'', 'Swift_CartSummary.cshtml', dynamicOffcanvas);
+					swift.PageUpdater.UpdateFromUrlInline(event, '/Default.aspx?ID=@(cartSummaryPageId)&CartType=minicart&RequestPageID=@(Pageview.Page.ID)&OrderContext=' + orderContext +'', 'Swift_CartSummary.cshtml', dynamicOffcanvas);
 				};
 
 				const openMiniCartOffcanvas = () => {