Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple prices (price matrix) through PriceProvider #18

Merged
merged 2 commits into from
May 14, 2024

Conversation

DWDBE
Copy link
Contributor

@DWDBE DWDBE commented May 3, 2024

No description provided.

@DWDBE DWDBE requested review from frederik5480 and mbengtson May 3, 2024 11:13
@frederik5480
Copy link
Contributor

@DWDBE I changed the version to 10.4.0 since we're changing the dependencies to 10.4.0 and made a branch based on the current master called milestones/10.0 so we can use the same-ish process as DW10, since if we need to do bugfixes for this repo in the future that should go down on 10.3 etc we'll need to have a version that's not depending on DW10.4

@DWDBE
Copy link
Contributor Author

DWDBE commented May 14, 2024

@DWDBE I changed the version to 10.4.0 since we're changing the dependencies to 10.4.0 and made a branch based on the current master called milestones/10.0 so we can use the same-ish process as DW10, since if we need to do bugfixes for this repo in the future that should go down on 10.3 etc we'll need to have a version that's not depending on DW10.4

@frederik5480 ok, thx, should I now merge this PR to main only or to a new milestones/10.0 branch? or to both?

@frederik5480
Copy link
Contributor

@DWDBE I changed the version to 10.4.0 since we're changing the dependencies to 10.4.0 and made a branch based on the current master called milestones/10.0 so we can use the same-ish process as DW10, since if we need to do bugfixes for this repo in the future that should go down on 10.3 etc we'll need to have a version that's not depending on DW10.4

@frederik5480 ok, thx, should I now merge this PR to main only or to a new milestones/10.0 branch? or to both?

Yeah this PR should be main only - we'll run latest on main, as soon as we then bump the dependencies we will make a milestone branch based on the dependency we're bumping from.
So any bugfixes in the future that's relevant to the 10.0.* versions should also be merged to them, and I will update the workflows so the milestone branches also gets pushed to nuget.

@DWDBE DWDBE merged commit c37e8e1 into main May 14, 2024
1 check passed
@DWDBE DWDBE deleted the dbe/10273-Support-multiple-prices-through-PriceProvider branch May 14, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants