Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix handling cookies is None in get_cookies #466

Merged
merged 3 commits into from
Dec 28, 2024
Merged

Conversation

devkral
Copy link
Contributor

@devkral devkral commented Dec 27, 2024

Checklist

  • The code has 100% test coverage. (it is basically the same with handling cookies is None)
  • The documentation was properly created or updated (if applicable) following the correct guidelines and appropriate language.
  • I branched out from the latest main or is a sub-branch.

Summary or description

Changes:

  • fix handling cookies is None in get_cookies
  • Optimize get_cookies
  • fix wrong example
  • remove left-over special handling of an empty string, lilya json encoding can do that now

Changes:
- fix handling cookies is None in get_cookies
- Optimize get_cookies
- fix wrong example
- remove left-over special handling of an empty string, lilya json
  encoding can do that now
- fix release notes
- add release note for cookie issue
@tarsil tarsil merged commit 9875537 into main Dec 28, 2024
9 checks passed
@tarsil tarsil deleted the devkral/fixes/cleanup branch December 28, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants