update release notes, provide tests

Note: the tests are failing

docs/en/docs/release-notes.md

@@ -24,6 +24,7 @@ hide:
 - `bytes` won't be encoded as json when returned from a handler. This would unexpectly lead to a base64 encoding.
 - SessionConfig has a unneccessarily heavily restricted secret_key parameter.
 - Gracefully handle situations where cookies are None in `get_cookies`.
+- Fix validation of parameters requiring a body.
 
 ## 3.6.1
 

tests/forms/test_forms_data.py

@@ -1,10 +1,12 @@
 from dataclasses import dataclass
-from typing import Any, Dict
+from typing import Any, Dict, Optional
 
+import pytest
 from pydantic import BaseModel
 from pydantic.dataclasses import dataclass as pydantic_dataclass
 
-from esmerald import Form, Gateway, post
+from esmerald import Form, Gateway, post, route
+from esmerald.exceptions import ImproperlyConfigured
 from esmerald.testclient import create_client
 
 
@@ -86,3 +88,11 @@ def test_send_complex_form_base_model(test_client_factory):
         response = client.post("/complex-form-basemodel", data=data)
         assert response.status_code == 201, response.text
         assert response.json() == {"id": 1, "name": "Test"}
+
+
+def test_get_and_head_data():
+    with pytest.raises(ImproperlyConfigured):
+
+        @route(methods=["GET", "HEAD"])
+        async def start(data: Optional[UserModel]) -> bytes:
+            return b"hello world"

tests/forms/test_forms_payload.py

@@ -1,10 +1,12 @@
 from dataclasses import dataclass
-from typing import Any, Dict
+from typing import Any, Dict, Optional
 
+import pytest
 from pydantic import BaseModel
 from pydantic.dataclasses import dataclass as pydantic_dataclass
 
-from esmerald import Form, Gateway, post
+from esmerald import Form, Gateway, post, route
+from esmerald.exceptions import ImproperlyConfigured
 from esmerald.testclient import create_client
 
 
@@ -86,3 +88,11 @@ def test_send_complex_form_base_model(test_client_factory):
         response = client.post("/complex-form-basemodel", data=payload)
         assert response.status_code == 201, response.text
         assert response.json() == {"id": 1, "name": "Test"}
+
+
+def test_get_and_head_payload():
+    with pytest.raises(ImproperlyConfigured):
+
+        @route(methods=["GET", "HEAD"])
+        async def start(payload: Optional[UserModel]) -> bytes:
+            return b"hello world"

tests/forms/test_forms_route.py

@@ -1,6 +1,10 @@
+from typing import Optional, Union
+
+import pytest
 from pydantic import BaseModel
 
 from esmerald import Esmerald, Form, Request
+from esmerald.exceptions import ImproperlyConfigured
 from esmerald.routing.gateways import Gateway
 from esmerald.routing.handlers import route
 from esmerald.testclient import EsmeraldTestClient
@@ -12,7 +16,21 @@ class Model(BaseModel):
 
 def test_get_and_post():
     @route(methods=["GET", "POST"])
-    async def start(request: Request, form: Model | None = Form()) -> bytes:
+    async def start(request: Request, form: Union[Model, None] = Form()) -> bytes:
+        return b"hello world"
+
+    app = Esmerald(
+        debug=True,
+        routes=[Gateway("/", handler=start)],
+    )
+    client = EsmeraldTestClient(app)
+    response = client.get("/")
+    assert response.status_code == 200
+
+
+def test_get_and_post_optional():
+    @route(methods=["GET", "POST"])
+    async def start(request: Request, form: Optional[Model] = Form()) -> bytes:
         return b"hello world"
 
     app = Esmerald(
@@ -22,3 +40,11 @@ async def start(request: Request, form: Model | None = Form()) -> bytes:
     client = EsmeraldTestClient(app)
     response = client.get("/")
     assert response.status_code == 200
+
+
+def test_get_and_head_form():
+    with pytest.raises(ImproperlyConfigured):
+
+        @route(methods=["GET", "HEAD"])
+        async def start(form: Optional[Model] = Form()) -> bytes:
+            return b"hello world"