Support yarn and pnpm@4 and upgrade deps including the godforsaken linter #365
Conversation
Artoria2e5
force-pushed
the
cli-refact
branch
from
61c1781 to
7eb0513
Compare
I have refactored the PM handling into one place through a thing called pm-speaker. It's like Lorax, but for package managers. Doing so should make things a lot easier when we want to support new PMs like pnpm@4.
and make sure we are linting everything (**) in lib
Artoria2e5
force-pushed
the
cli-refact
branch
2 times, most recently
from
ffe9208 to
ba01435
Compare
|
This is great, without it pnpm@4 fails to install |
Artoria2e5
force-pushed
the
cli-refact
branch
from
ba01435 to
367ae2e
Compare
The exit code 1 was previously used to indicate both "update available" and error. This messes up a bunch of CI tests. Now the "error" case is moved to exit code 2.
Artoria2e5
force-pushed
the
cli-refact
branch
from
d1233cb to
db0b350
Compare
| @@ -5,23 +5,26 @@ const ora = require('ora'); | |||
| const _ = require('lodash'); | |||
|
|
|||
| function skipUnused(currentState) { | |||
| return currentState.get('skipUnused') || // manual option to ignore this | |||
There was a problem hiding this comment.
…god. Sometimes linters are just bad at understanding human intent.
|
There are a few things I may want to rework in this repo, after this one as well as some other cool stuff gets merged (because they will mess up PR diffs):
|
|
Good luck 🤞 and big 👍 for your effort. That being said don't convert it to refactor everything pr especially not before you get some sort of signal from maintainers that they are interested in merging it. |
|
most of the diff is a side effect of updating the linter; it has some crazy new notions about indentation now... |
Artoria2e5
changed the title
|
Eventually this turned up to be even bigger clusterfuck than I initially envisioned. Not only that your work is sitting here unreviewed but it also got duplicated by: #368 & #371 and there is previous pr #361 that effectively became part of your proposed changes. (linking them for sake of visibility) As always mess will just continue to grow... 😩 |
|
Lmao, now we have #378 also being a subset of this PR. |
|
Oh god the new PR sets a FIXED version. I fecking hate this. |
ghost
|
@LinusU Could you please give this one a look? It it not actually 4000 lines of changes, I promise. |
This is built upon @vladimyr's yarn commit. To make things smoother I centralized the PM handling.
Some dependencies are upgraded because it looks like they should. These include depcheck and lodash with their respective vulnerbilities, as well as the xo linter because linters should be kept up-to-date. Although I have to say I disagree with plenty of xo's formatting suggestions...