Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bonsai-core): modifyUsdcAssetPosition #1423

Merged
merged 22 commits into from
Jan 15, 2025
Merged

feat(bonsai-core): modifyUsdcAssetPosition #1423

merged 22 commits into from
Jan 15, 2025

Conversation

jaredvu
Copy link
Contributor

@jaredvu jaredvu commented Jan 10, 2025

  • add calculator functions to create a list of operations which are then used to adjust parentSubaccountData
  • add selectors that take an input and modify parentSubaccountData before re-calculating to get a post op state.
  • add queries in DepositDialog2 and WithdrawDialog2

@jaredvu jaredvu requested a review from a team as a code owner January 10, 2025 23:07
@vercel Vercel
Copy link

vercel bot commented Jan 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 6:54pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 6:54pm

tyleroooo
tyleroooo reviewed Jan 13, 2025
View reviewed changes
src/views/dialogs/WithdrawDialog2/queries.ts Outdated Show resolved Hide resolved
src/views/dialogs/DepositDialog2/queries.ts Outdated Show resolved Hide resolved
src/abacus-ts/ontology.ts Outdated Show resolved Hide resolved
src/abacus-ts/ontology.ts Outdated Show resolved Hide resolved
src/abacus-ts/selectors/accountActions.ts Outdated Show resolved Hide resolved
src/abacus-ts/calculators/subaccount.ts Outdated Show resolved Hide resolved
src/abacus-ts/calculators/subaccount.ts Outdated Show resolved Hide resolved
src/abacus-ts/calculators/subaccount.ts Outdated Show resolved Hide resolved
src/abacus-ts/calculators/subaccount.ts Outdated Show resolved Hide resolved
src/abacus-ts/calculators/subaccount.ts Outdated Show resolved Hide resolved
tyleroooo
tyleroooo previously approved these changes Jan 13, 2025
View reviewed changes
src/abacus-ts/calculators/accountActions.ts Outdated Show resolved Hide resolved
Base automatically changed from jv/withdraw-rewrite-2 to main January 14, 2025 01:06
@jaredvu jaredvu dismissed tyleroooo’s stale review January 14, 2025 01:06

The base branch was changed.

@jaredvu jaredvu requested a review from tyleroooo January 14, 2025 01:19
tyleroooo
tyleroooo reviewed Jan 15, 2025
View reviewed changes
src/abacus-ts/calculators/accountActions.ts Outdated Show resolved Hide resolved
src/abacus-ts/calculators/accountActions.ts Outdated Show resolved Hide resolved
src/abacus-ts/calculators/accountActions.ts Outdated Show resolved Hide resolved
src/abacus-ts/calculators/accountActions.ts Outdated Show resolved Hide resolved
src/abacus-ts/calculators/accountActions.ts Outdated Show resolved Hide resolved
@jaredvu jaredvu requested a review from tyleroooo January 15, 2025 19:37
tyleroooo
tyleroooo approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@tyleroooo tyleroooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just nits

src/abacus-ts/calculators/accountActions.ts Show resolved Hide resolved
src/abacus-ts/calculators/accountActions.ts Show resolved Hide resolved
@jaredvu jaredvu merged commit 5218d74 into main Jan 15, 2025
9 checks passed
@jaredvu jaredvu deleted the jv/subaccount-operations-2 branch January 15, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyleroooo tyleroooo tyleroooo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaredvu @tyleroooo