Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.1.253: more affiliate progress card strings #843

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

tinaszheng
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-localization ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 8:52pm

@@ -800,12 +801,15 @@
"REFER_FOR_DISCOUNTS_FIRST_ORDER": "Receive up to {AMOUNT_USD} in fee discounts after placing your first order!",
"REFER_FOR_DISCOUNTS": "Refer a friend and they can receive up to ${AMOUNT_USD} in discounts.",
"REFEREE_BENEFITS": "The person you refer will save up to ${AMOUNT_USD} in fees.",
"REMAINING": "remaining",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably be {X} remaining in case other languages put the number behind the word, no?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreeeed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO when im in the mood for it later

"SHARE_AFFILIATE_BANNER_TITLE": "Trade over ${AMOUNT} to unlock your affiliate link",
"THE_PRO_TRADING_PLATFORM": "The Pro Trading Platform for DeFi",
"TOTAL_AFFILIATES": "Total Affiliates",
"TOTAL_EARNINGS": "Total Earnings",
"TRADE_ANYTHING_DISCRIPTION": "Any asset, any time. Don't see what you're looking for? List the market and be the first to trade it!",
"TRADE_ANYTHING": "Trade anything",
"TRADE_MORE_VOLUME_REQUIREMENT": "You will need to trade more volume.",
"TRADED": "traded",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar here?

Copy link
Contributor

@tyleroooo tyleroooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unblocking though

@tinaszheng tinaszheng merged commit 7355991 into main Nov 25, 2024
5 checks passed
@tinaszheng tinaszheng deleted the tina/1.1.253 branch November 25, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants