-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TRA-885] Upgrade handler to set market, perp and clob pair id to fixed number #2589
Open
shrenujb
wants to merge
5
commits into
main
Choose a base branch
from
tra885
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b0e5bda
Add upgrade to set market, perpetual and clob ids to a fixed number
shrenujb 7cf3fcd
Upgrade handler to set market, perp and clob pair id to fixed number
shrenujb fffb691
Merge branch 'main' into tra885
shrenujb 7993aa0
mockery stuff
shrenujb cfc11c8
Merge branch 'main' into tra885
shrenujb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Endpoint pattern is inconsistent across modules
The verification reveals inconsistent endpoint patterns for ID queries across different modules:
/dydxprotocol/perpetuals/next_perpetual_id
/dydxprotocol/prices/next_market_id
/dydxprotocol/clob/next_clob_pair_id
/dydxprotocol/v4/delaymsg/next_id
The
delaymsg
module uses a different pattern withv4
in the path, while others follow a consistentdydxprotocol/<module>/next_<resource>_id
pattern.🔗 Analysis chain
Verify endpoint pattern consistency.
Let's ensure the endpoint pattern for ID queries is consistent across different components (markets, perpetuals, clob pairs).
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 1206