Fix Skip transfer status #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruixhuang
commented
Oct 24, 2024
| @@ -855,6 +856,10 @@ internal class OnboardingSupervisor( | |||
| helper.post(url, null, body.toJsonPrettyPrint()) { _, response, httpCode, _ -> | |||
| if (response != null) { | |||
| update(stateMachine.routerTrack(response), oldState) | |||
| val isTracked = oldState?.trackStatuses?.get(hash) == true | |||
| if (isTracked) { | |||
| fetchTransferStatusSkip(hash, fromChainId) | |||
There was a problem hiding this comment.
Request status right away instead of waiting for the next timer trigger.
mike-dydx
approved these changes
Oct 24, 2024
| modified[txHash] = true | ||
| var txHash = parser.asString(payload.get("tx_hash")) ?: return modified | ||
| if (!txHash.startsWith("0x")) { | ||
| txHash = "0x$txHash" |
There was a problem hiding this comment.
i'm not sure we always want this though, what if the user submits a non EVM transaction? the tx hash may not necessarily start with 0x, right?
@ruixhuang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hash coming back from the skip endpoint doesn't have "0x" and is uppercased...