Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(metadata-url): Update assetId and get metadataService from env.json #715

Merged
merged 3 commits into from
Oct 17, 2024
Merged

chore(metadata-url): Update assetId and get metadataService from env.json #715

merged 3 commits into from
Oct 17, 2024

Conversation

jaredvu
Copy link
Contributor

@jaredvu jaredvu commented Oct 17, 2024

  • assetId was previously stripped of chain and address. Restore full assetId
  • Add metadataServiceInfo() to utilize env.json from web deployment

ruixhuang
ruixhuang reviewed Oct 17, 2024
View reviewed changes
src/commonMain/kotlin/exchange.dydx.abacus/output/Asset.kt

@JsExport
@Serializable
enum class AssetTags(val rawValue: String) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this getting used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that they could be exported for use purely on the client side

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the raw values are the coinmarketcap sector_tags that we want to support

@jaredvu jaredvu merged commit 0796110 into main Oct 17, 2024
3 checks passed
@jaredvu jaredvu deleted the jv/metadata-env branch October 17, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruixhuang ruixhuang ruixhuang approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaredvu @ruixhuang