Static Typing: Updating existing tests and bug fixes (2/n) #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ruixhuang
commented
Aug 28, 2024
•
ruixhuang
commented
- Updating all remaining tests other than those for transfers
- Updating PositionsNotificationProvider for static typing
- Fixing a trigger order calculation bug with the old codepath (see comment below)
# Conflicts: # src/commonMain/kotlin/exchange.dydx.abacus/state/internalstate/InternalState.kt # src/commonMain/kotlin/exchange.dydx.abacus/state/model/TradingStateMachine+Trades.kt
# Conflicts: # src/commonMain/kotlin/exchange.dydx.abacus/processor/markets/MarketProcessor.kt # src/commonMain/kotlin/exchange.dydx.abacus/processor/markets/MarketsProcessor.kt # src/commonMain/kotlin/exchange.dydx.abacus/processor/markets/MarketsSummaryProcessor.kt # src/commonTest/kotlin/exchange.dydx.abacus/processor/markets/MarketProcessorTests.kt # src/commonTest/kotlin/exchange.dydx.abacus/processor/markets/MarketsProcessorTests.kt # src/commonTest/kotlin/exchange.dydx.abacus/tests/mock/processor/markets/MarketProcessorMock.kt
… into feature/markets_4
This reverts commit d52adce.
…to feature/calc_1
# Conflicts: # src/commonMain/kotlin/exchange.dydx.abacus/processor/input/ClosePositionInputProcessor.kt # src/commonMain/kotlin/exchange.dydx.abacus/state/internalstate/InternalState.kt # src/commonMain/kotlin/exchange.dydx.abacus/state/model/TradingStateMachine.kt
# Conflicts: # src/commonTest/kotlin/exchange.dydx.abacus/payload/v4/V4TradeInputTests.kt
ruixhuang
commented
Aug 28, 2024
| @@ -284,7 +290,7 @@ internal class TriggerOrdersInputCalculator(val parser: ParserProtocol) { | |||
| OrderType.TakeProfitMarket, OrderType.StopMarket -> { | |||
| val triggerPrice = | |||
| parser.asDouble(parser.value(triggerOrder, "price.triggerPrice")) | |||
| val majorMarket = MAJOR_MARKETS.contains(parser.asString(triggerOrder["marketId"])) | |||
There was a problem hiding this comment.
"marketId" is located at the one level above instead of here. @moo-onthelawn
There was a problem hiding this comment.
ah marketId doesn't exist in data class TriggerOrder?
There was a problem hiding this comment.
Yeah, so the calculation is not correct :-(
jaredvu
reviewed
Aug 29, 2024
| @@ -100,18 +101,3 @@ internal fun TradingStateMachine.findOrder( | |||
| } ?: return null | |||
| return order | |||
| } | |||
|
|
|||
| internal fun TradingStateMachine.findOrderInData( | |||
jaredvu
previously approved these changes
Sep 3, 2024
jaredvu
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.