This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
v0.14.0: Add ExpiryV2 Contract #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrendanChou
force-pushed
the
bc_conclude
branch
from
4d86fef to
1c948fb
Compare
BrendanChou
commented
Aug 21, 2019
| uint256 marketId, | ||
| uint32 expiryTime | ||
| ) = parseCallArgs(data); | ||
| ExpiryArg[] memory expiries = abi.decode(data, (ExpiryArg[])); |
There was a problem hiding this comment.
Ethlint (aka solium) fails on this line, ruining the whole file duaraghav8/Ethlint#261
There was a problem hiding this comment.
"fixed in next release" - Apr 25 😢
There was a problem hiding this comment.
BrendanChou
force-pushed
the
bc_conclude
branch
2 times, most recently
from
63f4d07 to
dd3c3a1
Compare
| uint256 marketId, | ||
| uint32 expiryTime | ||
| ) = parseCallArgs(data); | ||
| ExpiryArg[] memory expiries = abi.decode(data, (ExpiryArg[])); |
There was a problem hiding this comment.
"fixed in next release" - Apr 25 😢
| uint256 marketId, | ||
| uint32 expiryTime | ||
| ) = parseCallArgs(data); | ||
| ExpiryArg[] memory expiries = abi.decode(data, (ExpiryArg[])); |
There was a problem hiding this comment.
BrendanChou
force-pushed
the
bc_conclude
branch
5 times, most recently
from
85659f1 to
6eb2976
Compare
| continue; | ||
| } else { | ||
| // bound the time by the minimum approved timeDelta | ||
| timeDelta = Math.max(minApprovedTimeDelta, exp.timeDelta).to32(); |
There was a problem hiding this comment.
Hmm... I wonder if this should do nothing instead of setting it to minApprovedTimeDelta
BrendanChou
force-pushed
the
bc_conclude
branch
6 times, most recently
from
fef6bdd to
1d74247
Compare
|
|
||
| // ============ Approval Functions ============ | ||
|
|
||
| function approveSender( |
There was a problem hiding this comment.
it's weird you also have to use the "approveSender" function to unapprove someone (by setting minTimeDelta to 0)
There was a problem hiding this comment.
would it better as "setApproval"?
AntonioJuliano
previously approved these changes
Aug 26, 2019
BrendanChou
force-pushed
the
bc_conclude
branch
from
8f002ed to
9d76bc5
Compare
AntonioJuliano
previously approved these changes
Aug 27, 2019
AntonioJuliano
approved these changes
Aug 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.