This repository has been archived by the owner on Mar 18, 2024. It is now read-only.
fix(namespace): fix namespaces on reported class names #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @JonnyPower for this first contribution! |
JonnyPower
force-pushed
the
issues/1362
branch
2 times, most recently
from
a552105 to
ce5507e
Compare
|
@azlam-abdulsalam any idea what the "Invalid time value" error is? don't believe it's related to my changes, but concerning because of the exit code ( 
|
|
Invalid time value unrelated. Caused by upstream. PR: forcedotcom/salesforcedx-apex#324 |
azlam-abdulsalam
requested review from
zhebinliu
and removed request for
azlam-abdulsalam
azlam-abdulsalam
approved these changes
Jul 24, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1365 +/- ##
=======================================
Coverage ? 47.01%
=======================================
Files ? 70
Lines ? 3099
Branches ? 659
=======================================
Hits ? 1457
Misses ? 1617
Partials ? 25 ☔ View full report in Codecov by Sentry. |
azlam-abdulsalam
pushed a commit
that referenced
this pull request
Aug 11, 2023
* fix(namespace): fix namespaces on reported class names Related to: #1362 * fix(apex-test): retry on Internal SF Error * fix(apex-test): update decision record
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1362
Summary generated by Reviewpad on 21 Jul 23 03:34 UTC
This pull request fixes namespaces on reported class names in the TriggerApexTests.ts file. It makes modifications to the
fixBadNamespaceClassFullNamesmethod to replace underscores with dots in class names. This ensures that the namespaces are correctly represented. The changes also include updating thetestResultandsecondTestResultvariables to apply the fixed namespaces.Checklist
All items have to be completed before a PR is merged