Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: setup,teardown -> setup_method, etc #133

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Conversation

dwhswenson
Copy link
Owner

@dwhswenson dwhswenson commented Jan 28, 2024

Pytest prefers (and now, apparently requires) the use of setup_method instead of setup.

Looks like there was also a problem to fix about newer pytest not liking pytest.warns(None) as a way to indicate that no warnings were issued.

Pytest prefers (and now, apparently requires) the use of `setup_method`
instead of `setup`.
Copy link

codecov bot commented Jan 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f276750) 89.27% compared to head (9932e68) 100.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##           master      #133       +/-   ##
============================================
+ Coverage   89.27%   100.00%   +10.72%     
============================================
  Files          13        13               
  Lines        1091      1154       +63     
============================================
+ Hits          974      1154      +180     
+ Misses        117         0      -117     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dwhswenson
Copy link
Owner Author

This is ready for review and comment. Without review, I will merge this after at least 24 hours, no sooner than Mon 29 Jan 17:00 GMT (11:00 my local).

@dwhswenson
Copy link
Owner Author

Noting here that the pytest.warns(None) issue had been previously solved by @sroet in #124, which I hadn't merged. I merged that one, hoping that credit will go where it is due. FWIW, the only difference (character-by-character) in our solutions were a single vs double quote (took @sroet's single) and that I had added a comment (kept my additional comment.)

@dwhswenson dwhswenson requested a review from sroet January 29, 2024 05:35
Copy link
Collaborator

@sroet sroet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge

@dwhswenson dwhswenson merged commit d80d300 into master Jan 29, 2024
9 checks passed
@dwhswenson dwhswenson deleted the pytest-setup-method branch January 29, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants