-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: setup
,teardown
-> setup_method
, etc
#133
Conversation
Pytest prefers (and now, apparently requires) the use of `setup_method` instead of `setup`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #133 +/- ##
============================================
+ Coverage 89.27% 100.00% +10.72%
============================================
Files 13 13
Lines 1091 1154 +63
============================================
+ Hits 974 1154 +180
+ Misses 117 0 -117 ☔ View full report in Codecov by Sentry. |
This was an old way to say that no warnings were issued. Updated behavior here, per: https://docs.pytest.org/en/7.0.x/how-to/capture-warnings.html#additional-use-cases-of-warnings-in-tests
This is ready for review and comment. Without review, I will merge this after at least 24 hours, no sooner than Mon 29 Jan 17:00 GMT (11:00 my local). |
Noting here that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, feel free to merge
Pytest prefers (and now, apparently requires) the use of
setup_method
instead ofsetup
.Looks like there was also a problem to fix about newer pytest not liking
pytest.warns(None)
as a way to indicate that no warnings were issued.