-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first step to fix dvd-dev/hilo#486 by making room to a second websock… #505
Draft
Leicas
wants to merge
17
commits into
dvd-dev:main
Choose a base branch
from
Leicas:fixissue#486
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
f4b24ef
first step to fix dvd-dev/hilo#486 by making room to a second websock…
Leicas b93d147
Initial linting
ic-dev21 f06d1c7
Update __init__.py
ic-dev21 4e2ac52
Update __init__.py
ic-dev21 db898b2
Some more progress
ic-dev21 77e2136
Ajout de stock dans le callback
ic-dev21 0a8cc12
Add logging and callback
ic-dev21 c6459d7
Update __init__.py
ic-dev21 8427c19
Linting
ic-dev21 8edec7e
Update __init__.py
ic-dev21 adb92d7
One more argument
ic-dev21 9e4ea39
Un autre
ic-dev21 061e9d3
This doesn't work causes error
ic-dev21 609e998
Update __init__.py
ic-dev21 6fbd36c
Update __init__.py
ic-dev21 bceefa5
Logging + linting/refactor
ic-dev21 0ed885e
Update __init__.py
ic-dev21 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition of
request_status_update_challenge
seems redundant given its similarity torequest_status_update
. Consider refactoring these methods to reduce code duplication, which will improve maintainability in case of future changes.