Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support heading IDs for jump links #264

Merged
merged 9 commits into from
Apr 7, 2024
Merged

Conversation

dustinwhisman
Copy link
Owner

@dustinwhisman dustinwhisman commented Apr 6, 2024

Description

Each heading past level 1 now gets an ID and a permalink to the heading element so people can link to specific sections. The permalink is hidden unless the heading is hovered or the link is focused, and the visually hidden text should make it clear to users what the link is for.

To Validate

  1. Make sure all PR Checks have passed
  2. Pull down this branch
  3. Run npm start

Copy link

netlify bot commented Apr 6, 2024

Deploy Preview for dustinwhisman ready!

Name Link
🔨 Latest commit 4ae1775
🔍 Latest deploy log https://app.netlify.com/sites/dustinwhisman/deploys/6612b220f68ec400083aafac
😎 Deploy Preview https://deploy-preview-264--dustinwhisman.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100
Accessibility: 100
Best Practices: 100
SEO: 100
PWA: 100
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@dustinwhisman dustinwhisman merged commit 3824ba3 into main Apr 7, 2024
8 checks passed
@dustinwhisman dustinwhisman deleted the feat--heading-ids branch April 7, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant