Enrich deploy method and contract's metadata with optional gas limit and gas price hint for free transactions #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miloszm
force-pushed
the
issue-357-limit-and-price-hint
branch
3 times, most recently
from
3a1d0b1
to
6a68f92
Compare
miloszm
force-pushed
the
issue-357-limit-and-price-hint
branch
from
6a68f92
to
ce772d8
Compare
ureeves
requested changes
May 30, 2024
ureeves
requested changes
May 31, 2024
There was a problem hiding this comment.
The ABI of ext::free_limit and ext::free_price_hint can solely be used to signal a None as opposed to also using the first byte in the argument buffer. It feels like repetition to use both. Are you trying to include information about the existance of the contract in the ABI?
Also, the cast to usize is unnecessary I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enrich deploy method and contract's metadata with optional gas limit and gas price hint for free transactions,
Implements issue #357