Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove check for is_ec2 when finding credentials (fixes #362) #363

Closed
wants to merge 1 commit into from
Closed

remove check for is_ec2 when finding credentials (fixes #362) #363

wants to merge 1 commit into from

Conversation

droundy
Copy link

@droundy droundy commented Oct 10, 2023

I just removed the is_ec2 and changed the first error to return NotEc2, so we would return a nice error in cases where the endpoint is not present at all.

@durch
Copy link
Owner

durch commented Oct 15, 2023

@droundy not sure about the change, the send can likely fail for a number of reasons, and always mapping it to EC2 seems worse then what is currently there

@durch
Copy link
Owner

durch commented Oct 16, 2023

Closing for now

@durch durch closed this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@droundy @durch