Skip to content

Commit

Permalink
Merge pull request lightningdevkit#2862 from arik-so/arik/2024/01/htt…
Browse files Browse the repository at this point in the history
…p-error-message-fix

Improve error message for invalid response lengths
  • Loading branch information
TheBlueMatt authored Jan 30, 2024
2 parents a634fd1 + bb9b389 commit 5bf58f0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lightning-block-sync/src/http.rs
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ impl HttpClient {
HttpMessageLength::Empty => { Vec::new() },
HttpMessageLength::ContentLength(length) => {
if length == 0 || length > MAX_HTTP_MESSAGE_BODY_SIZE {
return Err(std::io::Error::new(std::io::ErrorKind::InvalidData, "out of range"))
return Err(std::io::Error::new(std::io::ErrorKind::InvalidData, format!("invalid response length: {} bytes", length)));
} else {
let mut content = vec![0; length];
#[cfg(feature = "tokio")]
Expand Down Expand Up @@ -727,7 +727,7 @@ pub(crate) mod client_tests {
match client.get::<BinaryResponse>("/foo", "foo.com").await {
Err(e) => {
assert_eq!(e.kind(), std::io::ErrorKind::InvalidData);
assert_eq!(e.get_ref().unwrap().to_string(), "out of range");
assert_eq!(e.get_ref().unwrap().to_string(), "invalid response length: 8032001 bytes");
},
Ok(_) => panic!("Expected error"),
}
Expand Down

0 comments on commit 5bf58f0

Please sign in to comment.