Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: decouple worker threads from non-worker threads #1137

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

refactor: decouple worker threads from non-worker threads #1137

wants to merge 38 commits into from

Commits on Nov 1, 2024

  1. Decouple workers.

    @Alliballibaba2
    Alliballibaba2 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    fe1158f View commit details
    Browse the repository at this point in the history

  2. Moves code to separate file.

    @Alliballibaba2
    Alliballibaba2 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    ad34140 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. Cleans up the exponential backoff.

    @Alliballibaba2
    Alliballibaba2 committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    89b211d View commit details
    Browse the repository at this point in the history

  2. Initial working implementation.

    @Alliballibaba2
    Alliballibaba2 committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    7d2ab8c View commit details
    Browse the repository at this point in the history

  3. Refactors php threads to take callbacks.

    @Alliballibaba2
    Alliballibaba2 committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    f7e7d41 View commit details
    Browse the repository at this point in the history

  4. Cleanup.

    @Alliballibaba2
    Alliballibaba2 committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    c03c59b View commit details
    Browse the repository at this point in the history

  5. Cleanup.

    @Alliballibaba2
    Alliballibaba2 committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    a9857dc View commit details
    Browse the repository at this point in the history

  6. Cleanup.

    @Alliballibaba2
    Alliballibaba2 committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    bac9555 View commit details
    Browse the repository at this point in the history

  7. Cleanup.

    @Alliballibaba2
    Alliballibaba2 committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    a2f8d59 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2024

  1. Merge branch 'main' into refactor/start-worker-threads-directly

    @Alliballibaba2
    Alliballibaba2 committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    279924c View commit details
    Browse the repository at this point in the history

  2. Adjusts watcher logic.

    @Alliballibaba2
    Alliballibaba2 committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    0825453 View commit details
    Browse the repository at this point in the history

  3. Adjusts the watcher logic.

    @Alliballibaba2
    Alliballibaba2 committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    17d5cbe View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Fix opcache_reset race condition.

    @Alliballibaba2
    Alliballibaba2 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    09e0ca6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into refactor/start-worker-threads-directly 

    # Conflicts:
#	frankenphp.c
#	frankenphp.go
#	php_thread.go
#	worker.go
    @Alliballibaba2
    Alliballibaba2 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    a726a2c View commit details
    Browse the repository at this point in the history

  3. Fixing merge conflicts and formatting.

    @Alliballibaba2
    Alliballibaba2 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    7f13ada View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Prevents overlapping of TSRM reservation and script execution.

    @Alliballibaba2
    Alliballibaba2 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    13fb4bb View commit details
    Browse the repository at this point in the history

  2. Adjustments as suggested by @dunglas.

    @Alliballibaba2
    Alliballibaba2 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    a8a00c8 View commit details
    Browse the repository at this point in the history

  3. Adds error assertions.

    @Alliballibaba2
    Alliballibaba2 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    b4dd138 View commit details
    Browse the repository at this point in the history

  4. Adds comments.

    @Alliballibaba2
    Alliballibaba2 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    03f98fa View commit details
    Browse the repository at this point in the history

  5. Removes logs and explicitly compares to C.false.

    @Alliballibaba2
    Alliballibaba2 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    e52dd0f View commit details
    Browse the repository at this point in the history

  6. Resets check.

    @Alliballibaba2
    Alliballibaba2 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    cd98e33 View commit details
    Browse the repository at this point in the history

  7. Adds cast for safety.

    @Alliballibaba2
    Alliballibaba2 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    4e2a2c6 View commit details
    Browse the repository at this point in the history

  8. Fixes waitgroup overflow.

    @Alliballibaba2
    Alliballibaba2 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    c51eb93 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Resolves waitgroup race condition on startup.

    @Alliballibaba2
    Alliballibaba2 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    89d8e26 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Moves worker request logic to worker.go.

    @Alliballibaba2
    Alliballibaba2 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    3587243 View commit details
    Browse the repository at this point in the history

  2. Removes defer.

    @Alliballibaba2
    Alliballibaba2 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    ec32f0c View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Removes call from go to c.

    @Alliballibaba2
    Alliballibaba2 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    4e35698 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Merge branch 'main' into refactor/start-worker-threads-directly 

    # Conflicts:
#	frankenphp.go
    @Alliballibaba2
    Alliballibaba2 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    740fac7 View commit details
    Browse the repository at this point in the history

  2. Fixes merge conflict.

    @Alliballibaba2
    Alliballibaba2 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    8a272cb View commit details
    Browse the repository at this point in the history

  3. Adds fibers test back in.

    @Alliballibaba2
    Alliballibaba2 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    ecce5d5 View commit details
    Browse the repository at this point in the history

  4. Refactors new thread loop approach.

    @Alliballibaba2
    Alliballibaba2 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    06ebd67 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2024

  1. Removes redundant check.

    @Alliballibaba2
    Alliballibaba2 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    c811f4a View commit details
    Browse the repository at this point in the history

  2. Adds compareAndSwap.

    @Alliballibaba2
    Alliballibaba2 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    6bd047a View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2024

  1. Refactor: removes global waitgroups and uses a 'thread state' abstrac… 

    …tion instead.
    @Alliballibaba2
    Alliballibaba2 committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    55ad8ba View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into refactor/start-worker-threads-directly 

    # Conflicts:
#	worker.go
    @Alliballibaba2
    Alliballibaba2 committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    3ffbe06 View commit details
    Browse the repository at this point in the history

  3. Removes unnecessary method.

    @Alliballibaba2
    Alliballibaba2 committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    01ed92b View commit details
    Browse the repository at this point in the history

  4. Updates comment.

    @Alliballibaba2
    Alliballibaba2 committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    790cccc View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Removes unnecessary booleans.

    @Alliballibaba2
    Alliballibaba2 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    0dd2605 View commit details
    Browse the repository at this point in the history