Skip to content

Commit

Permalink
ci: golangci-lint config
Browse files Browse the repository at this point in the history
  • Loading branch information
dundee committed Apr 30, 2024
1 parent 64a8e17 commit d97bd4e
Show file tree
Hide file tree
Showing 2 changed files with 126 additions and 0 deletions.
122 changes: 122 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,122 @@
linters-settings:
errcheck:
check-blank: true
revive:
rules:
- name: blank-imports
- name: context-as-argument
- name: context-keys-type
- name: dot-imports
- name: error-return
- name: error-strings
- name: error-naming
- name: exported
- name: increment-decrement
- name: var-naming
- name: var-declaration
- name: package-comments
- name: range
- name: receiver-naming
- name: time-naming
- name: unexported-return
- name: indent-error-flow
- name: errorf
- name: empty-block
- name: superfluous-else
- name: unreachable-code
- name: redefines-builtin-id
# While we agree with this rule, right now it would break too many
# projects. So, we disable it by default.
- name: unused-parameter
disabled: true
gocyclo:
min-complexity: 25
dupl:
threshold: 100
goconst:
min-len: 3
min-occurrences: 3
lll:
line-length: 160
gocritic:
enabled-tags:
- diagnostic
- experimental
- opinionated
- performance
- style
disabled-checks:
- whyNoLint
funlen:
lines: 500
statements: 50
govet:
enable:
- shadow

linters:
disable-all: true
enable:
- bodyclose
- dogsled
- errcheck
- errorlint
- exhaustive
- exportloopref
- funlen
- goconst
- gocritic
- gocyclo
- gofmt
- goimports
- revive
- gosimple
- govet
- ineffassign
- lll
- nakedret
- staticcheck
- typecheck
- unparam
- unused
- whitespace

issues:
exclude:
# We allow error shadowing
- 'declaration of "err" shadows declaration at'

# Excluding configuration per-path, per-linter, per-text and per-source
exclude-rules:
# Exclude some linters from running on tests files.
- path: _test\.go
linters:
- gocyclo
- errcheck
- gosec
- funlen
- gocritic
- gochecknoglobals # Globals in test files are tolerated.
- goconst # Repeated consts in test files are tolerated.
# This rule is buggy and breaks on our `///Block` lines. Disable for now.
- linters:
- gocritic
text: "commentFormatting: put a space"
# This rule incorrectly flags nil references after assert.Assert(t, x != nil)
- path: _test\.go
text: "SA5011"
linters:
- staticcheck
- linters:
- lll
source: "^//go:generate "
- linters:
- lll
- gocritic
path: \.resolvers\.go
source: '^func \(r \*[a-zA-Z]+Resolvers\) '

output:
formats:
- format: colored-line-number
sort-results: true
4 changes: 4 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,9 @@ benchmark:
'gdu -npc ~' 'gdu -gnpc ~' 'gdu -npc --use-storage ~'
sudo cpupower frequency-set -g schedutil

lint:
golangci-lint run -c .golangci.yml

clean:
go mod tidy
-rm coverage.txt
Expand All @@ -151,5 +154,6 @@ install-dev-dependencies:
go install gotest.tools/gotestsum@latest
go install github.com/mitchellh/gox@latest
go install honnef.co/go/gotraceui/cmd/gotraceui@master
go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest

.PHONY: run build build-static build-all test gobench benchmark coverage coverage-html clean clean-uncompressed-dist man show-man release

0 comments on commit d97bd4e

Please sign in to comment.