Privacy Dashboard 8.0.0: Improved breakage form #3729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
afterxleep
approved these changes
Jan 15, 2025
mgurgel
force-pushed
the
mgurgel/improved-breakage-form
branch
from
deff857 to
783a83f
Compare
mgurgel
force-pushed
the
mgurgel/improved-breakage-form
branch
from
783a83f to
7ea9a8f
Compare
Task/Issue URL: https://app.asana.com/0/1206594217596623/1209173355503842/f **Description**: Set ups Privacy Dashboard EventMapping as to align with iOS. Each mapped event fires a pixel when invoked by the Privacy Dashboard. See duckduckgo/BrowserServicesKit#1167 Note: not all events are currently used by the Dashboard. Some are being deprecated, which is why they might not be fired at all even though they still exist in the mapping. **Steps to test this PR**: 1. Invoke the breakage form in the two possible ways: Open the Privacy Dashboard and click on "Report a problem with this site" Open the app menu ••• and click on "Report Broken Site” (iOS) 2. Confirm that the pixel `m_report-broken-site_shown` was fired 3. Submit a report 4. Confirm that the pixels `epbf_macos_desktop` and `m_report-broken-site_sent` were fired
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1209127604215386/f
CC: @jaceklyp
Description:
Upgrades Privacy Dashboard to 8.0.0, which contains the new site breakage flow as can be previewed here
Figma: https://www.figma.com/design/eeVdakW2pjijbDlv8HUSgZ/O-E---Report-Broken-Site-Flow-(Design-Updates-2024-09)?node-id=4024-6272&m=dev
Steps to test this PR:
Confirm that the breakage form matches the Figma or the web preview
Attempt to complete a broken site report from both entry points above. Things to keep an eye on:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation