-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support cosmetic filterlists #466
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muodov
force-pushed
the
cosmetic-easylist
branch
from
August 5, 2024 15:32
8fd0566
to
0f48f16
Compare
muodov
force-pushed
the
cosmetic-easylist
branch
from
October 16, 2024 15:58
f95d44c
to
92344bd
Compare
muodov
force-pushed
the
cosmetic-easylist
branch
from
October 16, 2024 16:02
92344bd
to
5a9db3b
Compare
muodov
added
major
Increment the major version when merged
release
Create a release when this pr is merged
labels
Oct 17, 2024
sammacbeth
requested changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just a couple of minor changes I think would improve it.
sammacbeth
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the optional support for cosmetic filterlist rules. Note that they are only used as a fallback, when autoconsent rules are not available for the given site. Autoconsent rules are still preferred as they can actively click reject buttons.
enableFilterList
config totrue
.Breaking changes:
import AutoConsent from '@duckduckgo/autoconsent'
will import the main library class. This was the main use-case before, so most likely your code will not break.import AutoConsent from '@duckduckgo/autoconsent/extra'
will import the same class with a bundled filterlist. While it will increase the site coverage, it will also significantly increase the bundle size.import rules from '@duckduckgo/autoconsent/rules/rules.json'
will import the JSON rules. This is added mainly for backward compatibility.require()
too.import DomActions from './node_modules/@duckduckgo/autoconsent/lib/dom-actions.ts'