Fix ANR in DuckPlayerLocalFilesPath

[CrisBarreiro]

Task/Issue URL: https://app.asana.com/0/1202552961248957/1208851110314077/f

Description

Steps to test this PR

Smoke test Duck Player

UI changes

Before	After
!(Upload before screenshot)	(Upload after screenshot)

[CrisBarreiro]

• Fix ANR in DuckPlayerLocalFilesPath #5340 👈 (View in Graphite)
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

[CDRussell]

@CrisBarreiro, would it make things easier to mark isSimulatedYoutubeNoCookie as a suspend function, instead of the changes in this PR?

• that’s the only thing I can see calling duckPlayerLocalFilesPath.assetsPath()
• isSimulatedYoutubeNoCookie is only ever called from coroutines anyway so there wouldn't be a large bubble-up effect of adding the suspend marker

if you did that, could ensure that duckPlayerLocalFilesPath.assetsPath() is called on the io dispatcher

[CrisBarreiro]

@CrisBarreiro, would it make things easier to mark isSimulatedYoutubeNoCookie as a suspend function, instead of the changes in this PR?

* that’s the only thing I can see calling `duckPlayerLocalFilesPath.assetsPath()`

* `isSimulatedYoutubeNoCookie` is only ever called from coroutines anyway so there wouldn't be a large bubble-up effect of adding the `suspend` marker

if you did that, could ensure that duckPlayerLocalFilesPath.assetsPath() is called on the io dispatcher

@CDRussell there's one usage that doesn't come from a suspend fun. However, since we're prefetching and caching the value of assetsPath, I don't think it's needed. Moreover, we removed all suspend functions in #5257, which fixed the prior ANR, so I would prefer to try this out first, and not go back to suspend functions that ultimately will require a runBlocking

[cmonfortep]

LGTM

[joshliebe]

Tested and works as expected ✅
This should fix the ANR, nicely done 👍