Omnibar: Pixel and Clear action regressions #5304
Open
+100
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1205782002757341/1208820359395089/f
Description
Steps to test this PR
Looks at this task for different scenarios: https://app.asana.com/0/1174433894299346/1208812333027437/f
Pixel for clearing address bar - Site
m_addressbar_focus_clear_entry_website
is fired only oncePixel for clearing address bar - SERP
m_addressbar_focus_clear_entry_serp
is fired only oncePixel for clearing address bar - NTP
m_addressbar_focus_clear_entry_ntp
is fired only onceSwipe gesture to close keyboard - Site
Swipe gesture to close keyboard - SERP
Manually close keyboard + Scroll- Site
Manually close keyboard + Scroll- SERP
Close keyboard - Site
Close keyboard - SERP