Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omnibar: Pixel and Clear action regressions #5304

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

malmstein
Copy link
Contributor

@malmstein malmstein commented Nov 21, 2024

Task/Issue URL: https://app.asana.com/0/1205782002757341/1208820359395089/f

Description

Steps to test this PR

Looks at this task for different scenarios: https://app.asana.com/0/1174433894299346/1208812333027437/f

Pixel for clearing address bar - Site

  • Navigate to a site
  • Tap into address bar
  • X to delete entry (don’t type anything new)
  • Swipe gesture to close keyboard
  • Verify pixel m_addressbar_focus_clear_entry_website is fired only once

Pixel for clearing address bar - SERP

  • Navigate to a site
  • Tap into address bar
  • X to delete entry (don’t type anything new)
  • Swipe gesture to close keyboard
  • Verify pixel m_addressbar_focus_clear_entry_serp is fired only once

Pixel for clearing address bar - NTP

  • Navigate to a site
  • Tap into address bar
  • X to delete entry (don’t type anything new)
  • Swipe gesture to close keyboard
  • Verify pixel m_addressbar_focus_clear_entry_ntp is fired only once

Swipe gesture to close keyboard - Site

  • Navigate to a site
  • Tap into address bar
  • X to delete entry (don’t type anything new)
  • Swipe gesture to close keyboard
  • Verify Site url is displayed

Swipe gesture to close keyboard - SERP

  • Enter a search query on SERP
  • Tap into address bar
  • X to delete entry (don’t type anything new)
  • Swipe gesture to close keyboard
  • Verify query is displayed

Manually close keyboard + Scroll- Site

  • Navigate to a site
  • Tap into address bar
  • X to delete entry (don’t type anything new)
  • Manually close keyboard
  • Scroll down the site
  • Verify Site url is displayed

Manually close keyboard + Scroll- SERP

  • Enter a search query on SERP
  • Tap into address bar
  • X to delete entry (don’t type anything new)
  • Manually close keyboard
  • Scroll down the site
  • Verify query is displayed

Close keyboard - Site

  • Ensure 3 button navigation is enabled (via device Settings)
  • Navigate to a site
  • Tap into address bar
  • X to delete entry (don’t type anything new)
  • Close keyboard (press back)
  • Verify Site url is displayed

Close keyboard - SERP

  • Ensure 3 button navigation is enabled (via device Settings)
  • Enter a search query on SERP
  • Tap into address bar
  • X to delete entry (don’t type anything new)
  • Close keyboard (press back)
  • Verify query is displayed

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@malmstein malmstein force-pushed the feature/david/11-21-omnibar_pixel_regressions branch 3 times, most recently from be29478 to 66a3c6d Compare November 26, 2024 09:46
@malmstein malmstein marked this pull request as ready for review November 26, 2024 16:06
@malmstein malmstein changed the title Omnibar: Pixel regressions Omnibar: Pixel and Clear action regressions Nov 26, 2024
@malmstein malmstein force-pushed the feature/david/11-21-omnibar_pixel_regressions branch from dd7e6c5 to eb67e00 Compare November 26, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant