Fix RMF unique pixel: adding tag as part of unique type #5207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @cmonfortep and the rest of your teammates on |
malmstein
approved these changes
Oct 30, 2024
aitorvs
pushed a commit
that referenced
this pull request
Nov 6, 2024
Task/Issue URL: https://app.asana.com/0/1207619243206445/1208647599954669/f ### Description When sending unique RMF pixel, include tag so we can differentiate between other remote message pixels. ### Steps to test this PR _Feature 1_ - [x] update remote message service to consume https://www.jsonblob.com/api/1284189194082443264 - [x] fresh install, and skip onboarding - [x] on NTP you will see RMF card - [x] ensure unique shown pixel is sent - [x] update config at https://www.jsonblob.com/1284189194082443264, removing the message just displayed and bump version - [x] restart the app - [x] on NTP you will see a new RMF card - [x] ensure unique shown pixel is sent - [x] restart the app - [x] on NTP you still see the previous RMF card - [x] ensure unique shown is not sent ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207619243206445/1208647599954669/f
Description
When sending unique RMF pixel, include tag so we can differentiate between other remote message pixels.
Steps to test this PR
Feature 1
UI changes