Update content scope scripts to version 6.25.0 #5206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task/Issue URL: https://app.asana.com/0/488551667048375/1208618045189439/f ### Description We need to make sure all attempts to access the `OmnibarLayout`’s ViewModel are checked to make sure the window is attached, otherwise the view may not be injected yet. ### Steps to test this PR - [ ] Enable _Don’t keep activities_ option in Developer options - [ ] Clear the app storage and start the app - [ ] Go through the flow until the omnibar is visible - [ ] Switch to a different app - [ ] Come back to the app - [ ] Notice the app doesn’t crash - [ ] Go to settings and change the omnibar position - [ ] Navigate back to the browser - [ ] Notice the app doesn’t crash
Task/Issue URL: https://app.asana.com/0/1198194956794324/1208351041752901/f ### Description Remove the `fixBlobDownloadWithIframes` kill switch and all the (deactivated) code behind it ### Steps to test this PR Just code review, we're removing code that doesn't execute
Task/Issue URL: https://app.asana.com/0/488551667048375/1208610845437915/f ### Description Removed temporary pixels for Indonesia message. ### Steps to test this PR Code review only. ### NO UI changes
Task/Issue URL: https://app.asana.com/0/488551667048375/1208621031521321/f ### Description Disable NTP for internal users ### Steps to test this PR _Open New Tab_ - [x] Open New Tab - [x] Verify you see the old version (no shortcuts)
- Automated content scope scripts dependency update This PR updates the content scope scripts dependency to the latest available version and copies the necessary files. If tests have failed, see https://app.asana.com/0/1202561462274611/1203986899650836/f for further information on what to do next. - [ ] All tests must pass Co-authored-by: daxmobile <[email protected]>
Task/Issue URL: https://app.asana.com/0/488551667048375/1208619432765760/f ### Description When a pulse animation is playing we don’t allow omnibar scrolling. In that scenario, if autocomplete results are visible, we are scrolloing over the transparent bar. ### Steps to test this PR _Feature 1_ - [x] Fresh install - [x] Visit a random site (ideally with trackers) - [x] Wait for the Dax dialog and pulse animation to start - [x] Focus url bar, and write something to make autocomplete appear - [x] scroll search results up - [x] see how the content doesn’t scrolling over the omnibar ### UI changes | Before | After | | ------ | ----- | |https://github.com/user-attachments/assets/c9d2ea9a-1eab-48ee-8b0d-f1de5c03483e|
Task/Issue URL: https://app.asana.com/0/0/1208258165749225/f ### Description This is the main PR for the implementation of the VPN auto-exclude broken apps feature ### Steps to test this PR https://app.asana.com/0/0/1208316334284044/f
Task/Issue URL: https://app.asana.com/0/72649045549333/1208618749197984/f ### Description Bumps to Autofill v15 (version containing the revert of iframes support) ### Steps to test this PR - E2E tests are green https://github.com/duckduckgo/Android/actions/runs/11498807179 - Perform smoke testing ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)|
Task/Issue URL: https://app.asana.com/0/1201807753394693/1208602127384122/f ### Description Add a pixel that is fired when error page is displayed ### Steps to test this PR _Error page pixel_ - [x] Instal from branch - [x] Put phone in airplane mode - [x] Visit a site and check error page is shown - [x] Go to logcat and filter by `m_errorpageshown` - [x] Check `Pixel failed: 1 m_errorpageshown` is logged - [x] Disable airplane mode - [x] Close the app - [x] Open the app again - [x] Check `Pixel sent: 1 m_errorpageshown` is logged _Error page pixel disabled_ - [x] Instal from branch - [x] Go to _Settings > Feature Flag Inventory_ and disable `errorPagePixel` FF - [x] Put phone in airplane mode - [x] Visit a site and check error page is shown - [x] Go to logcat and filter by `m_errorpageshown` - [x] Check `Pixel failed: 1 m_errorpageshown` is **not** logged ### No UI changes
…ggest (#5018) Task/Issue URL: https://app.asana.com/0/1200581511062568/1208260875798966/f ### Description The full implementation will span across a few tasks. This is the main task for the implementation of [Android: Include existing open tabs in search autosuggest](https://app.asana.com/0/715106103902962/1208040193300233/f) ### Steps to test this PR See: - #5019 - #5042 - #5063 - #5064 - #5065 - #5105 - #5123 See scenarios and screenshots in https://app.asana.com/0/1200581511062568/1208264037618741/f --------- Co-authored-by: Dax The Translator <[email protected]>
- Automated content scope scripts dependency update This PR updates the content scope scripts dependency to the latest available version and copies the necessary files. If tests have failed, see https://app.asana.com/0/1202561462274611/1203986899650836/f for further information on what to do next. - [ ] All tests must pass Co-authored-by: daxmobile <[email protected]>
Task/Issue URL: https://app.asana.com/0/1202552961248957/1208628973892718/f ### Description Only add Origin param if query will navigate to Duck Player ### Steps to test this PR _Test origin param is still added if navigating to Duck Player_ - [x] Set Duck Player to Always - [x] Search for a video - [x] Click on a search result for a video - [x] Check query param `origin=serp_auto` is added _Test origin param is still added if navigating to Duck Player and opening in new tab_ - [x] Open FF inventory and enable "Duck player > open in new tab" - [x] Set Duck Player to Always and enable open in new tab - [x] Search for a video - [x] Click on a search result for a video - [x] Check query param `origin=serp_auto` is added and the video is opened in a new tab _Test origin param is not added if not navigating to Duck Player_ - [x] Set Duck Player to Always - [x] Search for a nytimes - [x] Open nytimes site - [x] Check query param `origin=serp_auto` is not added
Task/Issue URL: https://app.asana.com/0/1174433894299346/1208617452367951/f ### Description Add push permissions to GHA Working as per https://github.com/duckduckgo/Android/actions/runs/11507256944/job/32033015991 --------- Co-authored-by: Aitor Viana <[email protected]>
Task/Issue URL: https://app.asana.com/0/1174433894299346/1208611782328138/f ### Description This PR updates the TextAlertDialog with a few things: - Adds a checkbox - Allows for button configuration The destructive combination was using the wrong type of buttons, so we added a GhostAlt version that can now be used. ### Steps to test this PR _ADS Demo_ - [x] Open ADS Demo - [x] Navigate to Dialogs tab - [ ] Verify dialogs look as expectec\
Task/Issue URL: https://app.asana.com/0/1205648422731273/1208638453759884/f ### Description ### Steps to test this PR _TextAlertDialog_ - [x] Navigate to Settings -> Appearance - [x] Tap on "Force Websites To Use Dark Theme" - [x] In the dialog, tap "Relaunch Now" - [x] Verify that the app was restarted _RadioListAlertDialog_ - [x] Navigate to Settings -> Fire Button - [x] Tap on "Automatically Clear..." - [x] In the dialog, change selected option and tap "Save" - [x] Verify that setting value in the UI has been updated ### No UI changes
|
Superseded by #5306 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1208645646305847/f
This PR updates the content scope scripts dependency to the latest available version and copies the necessary files.
If tests have failed, see https://app.asana.com/0/1202561462274611/1203986899650836/f for further information on what to do next.