Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IllegalArgumentException when savedSiteAdded #5155

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

joshliebe
Copy link
Contributor

@joshliebe joshliebe commented Oct 18, 2024

Task/Issue URL: https://app.asana.com/0/488551667048375/1208580918293540/f

Description

Steps to test this PR

Add bookmark

  • Go to a site
  • Tap the overflow and “Add Bookmark"
  • Verify that the BottomSheetDialog dismisses automatically

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joshliebe and the rest of your teammates on Graphite Graphite

@nalcalag nalcalag self-assigned this Oct 22, 2024
Copy link
Contributor

@nalcalag nalcalag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joshliebe joshliebe merged commit 0daa459 into develop Oct 22, 2024
9 checks passed
@joshliebe joshliebe deleted the bugfix/josh/saved-site-added-exception branch October 22, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants