Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHA: Create Tag task #5060

Merged
merged 23 commits into from
Oct 17, 2024
Merged

GHA: Create Tag task #5060

merged 23 commits into from
Oct 17, 2024

Conversation

malmstein
Copy link
Contributor

@malmstein malmstein commented Sep 25, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/488551667048375/1208234576573037/f

Description

  • This PR adds a new workflow that creates a release tag
  • It also adds a new workflow to launch release tests in Maestro
  • A new general release workflow has been added, that runs the create task admin and create tag workflow.

Steps to test this PR

@malmstein Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @malmstein and the rest of your teammates on Graphite Graphite

@malmstein malmstein force-pushed the feature/david/09-25-gha_create_tag_task branch from 3e49b5c to 031b9b5 Compare October 7, 2024 08:57
@malmstein malmstein marked this pull request as ready for review October 7, 2024 09:05
@malmstein malmstein force-pushed the feature/david/09-25-gha_create_tag_task branch 2 times, most recently from d3ded20 to fafb03e Compare October 16, 2024 14:13
@malmstein
GHA: Create Tag task
f529061
@malmstein
added general task to perform a release
c07b6ab
@malmstein
remove need clause from first job
087eb58
@malmstein
using same placeholder as other jobs
8d08a4c
@malmstein
specify production release
17cc452
@malmstein
add step to launch release tests
473c21e
@malmstein
need to move report error to a workflow
5a76f5a
@malmstein
moved release workflows to it's own folder
efe3ca0
@malmstein
report error task created
c6dea1b
@malmstein
fix release workflow paths
c9d4d44
@malmstein
rollback docs changes
d858b95
@malmstein
smoke test release task
230351c
@malmstein
workflows need to be in root directory
697244b
@malmstein
can only test tag task
a50848d
@malmstein
using macos runner
d06bb6b
@malmstein
ensure we get fastlane configured
a07c386
@malmstein
recursive checkout and proper fastlane lane
546c2e6
@malmstein
test launch release tests in maestro
a873442
@malmstein
add to git ignore
fd53494
@malmstein
rollback docs
1a2be8b
@malmstein
rollback fastlane gitignore
c0f155e
@malmstein
remove check for branch in fastfile
d592656
@malmstein
rollback docs
c89a8df
@malmstein malmstein force-pushed the feature/david/09-25-gha_create_tag_task branch from d28903d to c89a8df Compare October 17, 2024 10:19
marcosholgado
marcosholgado approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malmstein malmstein merged commit 38f92bd into develop Oct 17, 2024
7 checks passed
@malmstein malmstein deleted the feature/david/09-25-gha_create_tag_task branch October 17, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosholgado marcosholgado marcosholgado approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malmstein @marcosholgado