Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial version of alpine docker #125

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

adsharma
Copy link

@adsharma adsharma commented Dec 26, 2024

This docker attempts to create an environment where an extension author can simply mount their extension within a pre-built image and get it to build.

This image doesn't quite do that yet. But hopefully a starting point for further discussion and feedback.

More context

Usage:

docker buildx build -t duckdb_ext_tools:latest . --load -f docker/linux_amd64/alpine/Dockerfile
docker run -v $(pwd):/duckdb_build_dir/my_extension --env-file=docker/linux_amd64/alpine/env.txt -it  duckdb_ext_tools:latest

@carlopi carlopi self-requested a review December 26, 2024 19:37
@adsharma
Copy link
Author

adsharma commented Jan 6, 2025

Couple of notes here:

I was able to mount an extension inside this docker and build it and run some tests.

However to make it more useful, we need to figure out:

  • How to publish the built docker to docker hub or similar
  • What should be inside such a image? Do we want to include ccache? All of duckdb build artifacts or only what's needed to build an extension?
  • Now if the extension developer wants to build their own extension inside this docker, they'll have two extensions
/duckdb_build_dir/extension_docker_image_built_with
/duckdb_build_dir/my_extension

How does my_extension refer to the duckdb dir in extension_docker_image_built_with?

Perhaps we can first get this PR reviewed/merged and then discuss the issues above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants