Dtenwolde's CI checks ++

.github/workflows/TestCITools.yml

@@ -61,3 +61,13 @@ jobs:
       duckdb_version: v1.1.3
       exclude_archs: 'wasm_mvp;wasm_eh;wasm_threads;windows_amd64_rtools;windows_amd64'
       extra_toolchains: 'rust'
+
+  code-quality-check:
+    name: Code quality check
+    uses: ./.github/workflows/_extension_code_quality.yml
+    with:
+      override_repository: duckdb/extension-template
+      override_ref: main
+      duckdb_version: v1.1.3
+      override_ci_tools_repository: ${{ github.repository }}
+      ci_tools_version: ${{ github.sha }}

.github/workflows/_extension_code_quality.yml

@@ -0,0 +1,89 @@
+name: CodeQuality
+
+on:
+  workflow_call:
+    inputs:
+      explicit_checks:
+        required: false
+        type: string
+      duckdb_version:
+        required: true
+        type: string
+      ci_tools_version:
+        required: true
+        type: string
+      # Override the repo for the CI tools (for testing CI tools itself)
+      override_ci_tools_repository:
+        required: false
+        type: string
+        default: "duckdb/extension-ci-tools"
+      override_repository:
+        required: false
+        type: string
+        default: ""
+      # The git ref used for the override_repository
+      override_ref:
+        required: false
+        type: string
+        default: ""
+
+
+jobs:
+  format-check:
+    name: Format Check
+    runs-on: ubuntu-20.04
+
+    env:
+      CC: gcc-10
+      CXX: g++-10
+      GEN: ninja
+
+    steps:
+      - uses: actions/checkout@v4
+        name: Checkout override repository
+        if: ${{inputs.override_repository != ''}}
+        with:
+          repository: ${{ inputs.override_repository }}
+          ref: ${{ inputs.override_ref }}
+          fetch-depth: 0
+          submodules: 'true'
+
+      - uses: actions/checkout@v4
+        name: Checkout current repository
+        if: ${{inputs.override_repository == ''}}
+        with:
+          fetch-depth: 0
+          submodules: 'true'
+
+      - uses: actions/checkout@v4
+        name: Checkout Extension CI tools
+        with:
+          path: 'extension-ci-tools'
+          ref: ${{ inputs.ci_tools_version }}
+          repository: ${{ inputs.override_ci_tools_repository }}
+
+      - name: Checkout DuckDB to version
+        if: ${{inputs.duckdb_version != ''}}
+        run: |
+          DUCKDB_GIT_VERSION=${{ inputs.duckdb_version }} make set_duckdb_version
+
+      - name: Install
+        shell: bash
+        run: sudo apt-get update -y -qq && sudo apt-get install -y -qq ninja-build clang-format-11 && sudo pip3 install cmake-format black cxxheaderparser pcpp
+
+      - name: List Installed Packages
+        shell: bash
+        run: pip3 freeze
+
+      - name: Format Check
+        shell: bash
+        run: |
+          clang-format --version
+          clang-format --dump-config
+          black --version
+          make format-check-silent
+
+      - name: Generated Check
+        shell: bash
+        run: |
+          git diff --ignore-submodules --exit-code

makefiles/duckdb_extension.Makefile

@@ -132,9 +132,15 @@ wasm_threads:
 	emmake make -j8 -Cbuild/wasm_threads
 
 #### Misc
-format:
-	find src/ -iname *.hpp -o -iname *.cpp | xargs clang-format --sort-includes=0 -style=file -i
-	cmake-format -i CMakeLists.txt
+# Rule to fix formatting
+format-check:
+	python extension-ci-tools/scripts/format_extension.py
+
+format-check-silent:
+	python extension-ci-tools/scripts/format_extension.py --all --check --silent
+
+format-fix:
+	python extension-ci-tools/scripts/format_extension.py --all --fix --noconfirm
 
 update:
 	git submodule update --remote --merge