Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable extension loading in node #1454

Merged
merged 6 commits into from
Oct 25, 2023
Merged

Enable extension loading in node #1454

merged 6 commits into from
Oct 25, 2023

Conversation

carlopi
Copy link
Collaborator

@carlopi carlopi commented Oct 19, 2023

Still using the patch, to be moved to external component but I am trying to find the proper place for the refactor.

Idea is this:

  • if you are on a browser, you have XMLHttpRequest, use that to perform requests.
  • if you are on node, and the file is available locally, use that
  • otherwise, spawn a Worker, and via a combination of postMessage and Atomics, have the worker use async fetch made that will appear synchronous to the C++ code due to the wait

This makes node test passing, and it's the last blocker for tagging a version on npm.

@carlopi carlopi marked this pull request as draft October 19, 2023 13:29
@carlopi carlopi force-pushed the node branch 2 times, most recently from 694e407 to ea5b7fb Compare October 19, 2023 15:05
@carlopi carlopi marked this pull request as ready for review October 20, 2023 12:52
@Mytherin Mytherin merged commit 9eaa37e into duckdb:main Oct 25, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants