Fixed: ODBC DSN connection always used :memory: no matter what you set in odbc.ini

[kkovacs]

This PR should be fixing #29 .

The issue appears to be that if one uses SQLConnect() (as opposed to SQLDriverConnect(), then dbc->dsn is never set, and thus this part of the .ini parsing function always returns before even parsing the .ini file.

Here:

SQLRETURN Connect::ReadFromIniFile() {
#if defined ODBC_LINK_ODBCINST || defined WIN32
	if (dbc->dsn.empty()) {
		return SQL_SUCCESS;
	}

at https://github.com/duckdb/duckdb-odbc/blob/154f517dadc60efc5d802650c1e572a786992a4e/src/connect/connect.cpp#L98C1-L103C1

I've tested the fix on Linux (Ubuntu 24.04).

Edit: added reference to the original issue, typo

[kkovacs]

Hi guys, can someone kick the tests to re-run? I doubt that the sh -c "cat /etc/*release | grep ^ID error would be related to my change...

[kkovacs]

Maybe I can ask you @guenp to have a look at why checks fail with shell errors...?

[malcook]

hi - I reported #29 and am happy to see this progress.

If there is any way I can assist in testing these changes before release, please advise how to deploy these changes, and I will try to help.

[guenp]

Thank you @kkovacs and @malcook ! I will take a look and test it