Bump to duckdb v1.1.3 #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hannes: do we want also v1.1.2 in? I think there are no proper uses, so I cut that corner. |
|
I think 113 is enough thanks |
hannes
reviewed
Nov 13, 2024
| @@ -2,7 +2,7 @@ | |||
| "name": "duckdb", | |||
| "main": "./lib/duckdb.js", | |||
| "types": "./lib/duckdb.d.ts", | |||
| "version": "0.0.2-dev5.0", | |||
| "version": "1.1.3", | |||
There was a problem hiding this comment.
@carlopi changing this broke the release :/ npm error Version not changed
There was a problem hiding this comment.
Yes, I saw, not great.
My proposed solution would be:
- merging Revert change to package.json #140 that reverts the changes
- check if CI starts correctly after the merge
- re-targeting the
v1.1.3tag to what would be the new main. This is not clean but should be viable on GitHub.
NPM has no notion of v1.1.3, so the only problem should be changing releases on Github.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(relying on CI to actually check this)
Merging, checking CI on main, then tagging, solves #138
There is an issue also on v1.1.2 on npm (#135), that is also solved by this.