Skip to content

Commit

Permalink
no tests on release
Browse files Browse the repository at this point in the history
  • Loading branch information
hannes committed Oct 3, 2023
1 parent 4c12baa commit 1c8c0a5
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
4 changes: 3 additions & 1 deletion scripts/node_build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ npm install --build-from-source --target_arch="$TARGET_ARCH"
./node_modules/.bin/node-pre-gyp reveal --target_arch="$TARGET_ARCH"

if [[ "$TARGET_ARCH" != "arm64" ]] ; then
npm test
if [[ ! "$GITHUB_REF" =~ ^(refs/tags/v.+)$ ]] ; then
npm test
fi
else
ARCH=$(file lib/binding/duckdb.node | tr '[:upper:]' '[:lower:]')
if [[ "$ARCH" != *"arm"* ]] ; then
Expand Down
6 changes: 5 additions & 1 deletion scripts/node_build_win.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,13 @@ which node
make clean

npm install --build-from-source
npm test
# no tests on releases
if [[ ! "$GITHUB_REF" =~ ^(refs/tags/v.+)$ ]] ; then
npm test
fi
npx node-pre-gyp package testpackage testbinary


# TODO
# if [[ "$GITHUB_REF" =~ ^(refs/heads/main|refs/tags/v.+)$ ]] ; then
# npx node-pre-gyp publish
Expand Down

0 comments on commit 1c8c0a5

Please sign in to comment.