Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix https://github.com/duckdb/duckdb-java/issues/66 #67

Merged

Conversation

rpbouman
Copy link
Contributor

@rpbouman rpbouman commented Aug 23, 2024

I wanted to check something around Blob handling and checked out the repo, built it, ran the tests and found two tests failing (TestDuckDBJDBC#test_all_types and TestDuckDBJDBC#test_struct_with_bad_type)

This PR fixes those tests.

For TestDuckDBJDBC#test_all_types:

  • This adds a check to see if the correct_answer_map has values for the column so that the column name can be reported in case the map is not populated for every column from test_all_types.
  • It also populates the map with the required values to allow the test to pass.

For TestDuckDBJDBC#test_struct_with_bad_type:

  • the assert tried to test by matching the error message with a wrong error message. Or rather, most likely the error message that was tested used to be returned by DuckDB but has changed in the mean while.

@rpbouman
Copy link
Contributor Author

I'm sorry to PR test failed. I tried to figure it out but I believe the compliance action is broken, as it's complaining that it cannot find classes from the test harness itself.

@Mause Mause merged commit 2dcea62 into duckdb:main Aug 25, 2024
6 of 7 checks passed
@Mause
Copy link
Member

Mause commented Aug 25, 2024

I'm sorry to PR test failed. I tried to figure it out but I believe the compliance action is broken, as it's complaining that it cannot find classes from the test harness itself.

Yeah it's broken at the moment, need to get around to fixing it

Cheers for the other fixes though!

@rpbouman rpbouman deleted the issue-66-test_all_types-fails-for-varint-column branch August 25, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants